Improve readability of item deletion procedure

[claucambra]

No description provided.

[Copilot]

Pull Request Overview

This PR aims to improve the readability and maintainability of the item deletion procedure by restructuring the logic and clarifying internal metadata handling.

• Splits deletion logic into two private functions: one for deletion and one for trash metadata modification.
• Revises guard conditions and comments to better express the intent of the trashing parameter.

Comments suppressed due to low confidence (3)

Sources/NextcloudFileProviderKit/Item/Item+Delete.swift:91

• [nitpick] The function name 'handleMetadataDeletion' might be misleading since it's invoked when the trashing flag is false. Consider renaming it to better reflect its behavior in relation to the trashing parameter.

private func handleMetadataDeletion() {

Sources/NextcloudFileProviderKit/Item/Item+Delete.swift:100

• [nitpick] Consider revising this comment to more clearly describe the steps required after a trash modification, and to explain how it complements the deletion path.

// NOTE: the trashing metadata modification procedure here is rough. You SHOULD run a rescan of ...

Sources/NextcloudFileProviderKit/Item/Item+Delete.swift:84

• [nitpick] The guard condition now inverts the original logic. Consider adding an inline comment that clearly explains when the deletion versus trash modification paths are executed.

guard trashing else {

[codecov]

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.11%. Comparing base (52e92f5) to head (0dd740a).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...es/NextcloudFileProviderKit/Item/Item+Delete.swift	79.48%	8 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   81.11%   81.11%           
=======================================
  Files          62       62           
  Lines       13039    13046    +7     
=======================================
+ Hits        10576    10582    +6     
- Misses       2463     2464    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.