Do not try to evict an item on disabling keep downloaded#76
Merged
Conversation
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logic for handling the "keep downloaded" flag by removing the eviction call when an item is already downloaded and the flag is disabled.
- Removed the call to evict a downloaded item on disabling "keep downloaded".
- Now, regardless of the download state, the manager is instructed to modify the item's last used date.
Comments suppressed due to low confidence (1)
Sources/NextcloudFileProviderKit/Item/Item+KeepDownloaded.swift:32
- [nitpick] Consider adding an inline comment to explain the reasoning behind removing the eviction logic, to help future maintainers understand that this is an intentional design decision.
else if !keepDownloaded && isDownloaded { try await manager.evictItem(identifier: itemIdentifier) }
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 81.07% 81.10% +0.02%
==========================================
Files 62 62
Lines 13507 13505 -2
==========================================
+ Hits 10951 10953 +2
+ Misses 2556 2552 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.