Skip to content

Log the specific error occurring during auth check#84

Merged
claucambra merged 2 commits into
mainfrom
feature/auth-error-log
Jun 10, 2025
Merged

Log the specific error occurring during auth check#84
claucambra merged 2 commits into
mainfrom
feature/auth-error-log

Conversation

@claucambra
Copy link
Copy Markdown
Contributor

No description provided.

@claucambra claucambra added this to the 3.0 milestone May 30, 2025
@claucambra claucambra requested a review from Copilot May 30, 2025 05:49
@claucambra claucambra self-assigned this May 30, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves error logging by capturing specific errors encountered during the auth check in NextcloudKit. Changes include:

  • Adding a new logger instance in the authentication check.
  • Logging detailed error information when authentication fails.

Comment thread Sources/NextcloudFileProviderKit/Interface/NextcloudKit+RemoteInterface.swift Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (afd311e) to head (e4817eb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...erKit/Interface/NextcloudKit+RemoteInterface.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   83.85%   83.84%   -0.01%     
==========================================
  Files          70       70              
  Lines       15599    15603       +4     
==========================================
+ Hits        13080    13082       +2     
- Misses       2519     2521       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra force-pushed the feature/auth-error-log branch from 71e0072 to 5af117f Compare June 10, 2025 08:51
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra force-pushed the feature/auth-error-log branch from 5af117f to e4817eb Compare June 10, 2025 08:52
@claucambra claucambra merged commit 3423917 into main Jun 10, 2025
1 of 3 checks passed
@claucambra claucambra deleted the feature/auth-error-log branch June 10, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants