Implement more gentle depth-1 paginated PROPFIND approach for working set enumeration#85
Merged
Merged
Conversation
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
It's not used by any users of this library and there is no interest in this feature Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…ystem and custom pagination tokens for this Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…or when handling working set folders Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…ed propfinds Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a more gentle depth-1 paginated PROPFIND approach for working set enumeration by adding new tests and updating the enumerator’s pagination behavior. Key changes include:
- New tests in EnumeratorTests.swift for paginated enumeration in various folder scenarios.
- Updates in Enumerator.swift to support recursive working set pagination (including handling of next server URLs).
- Removal of legacy listener interfaces and their tests.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/NextcloudFileProviderKitTests/EnumeratorTests.swift | Adds tests for working set, empty folder, and few-items paginated enumerations while removing the legacy listener test. |
| Tests/Interface/MockRemoteInterface.swift | Adds an assertion to ensure valid array slicing for paginated requests. |
| Tests/Interface/MockEnumerationListener.swift | Removes the legacy mock enumeration listener implementation. |
| Sources/NextcloudFileProviderKit/Reporting/EnumerationListener.swift | Removes the legacy enumeration listener protocol. |
| Sources/NextcloudFileProviderKit/Enumeration/EnumeratorPageResponse.swift | Adds an initializer to support nextServerUrl-based pagination. |
| Sources/NextcloudFileProviderKit/Enumeration/Enumerator.swift | Refactors pagination handling by removing listener callbacks and adding new logic for working set pagination. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 82.57% 83.00% +0.43%
==========================================
Files 71 70 -1
Lines 14630 14924 +294
==========================================
+ Hits 12080 12388 +308
+ Misses 2550 2536 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.