Skip to content

Fully handle permissions in Item capabilities#86

Merged
claucambra merged 4 commits into
mainfrom
bugfix/capabilities
Jun 6, 2025
Merged

Fully handle permissions in Item capabilities#86
claucambra merged 4 commits into
mainfrom
bugfix/capabilities

Conversation

@claucambra
Copy link
Copy Markdown
Contributor

No description provided.

…lities

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…f items

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra added this to the 3.0 milestone Jun 6, 2025
@claucambra claucambra requested a review from Copilot June 6, 2025 06:08
@claucambra claucambra self-assigned this Jun 6, 2025
@claucambra claucambra added the bug Something isn't working label Jun 6, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fully handle permissions for Item capabilities by revising the logic to compute the capabilities based on metadata permissions and other flags.

  • Updates capability determination by checking permission characters and metadata properties
  • Replaces the earlier guard for locked metadata with inline checks and adjusts the handling for directories and files

Comment thread Sources/NextcloudFileProviderKit/Item/Item.swift
Comment thread Sources/NextcloudFileProviderKit/Item/Item.swift Outdated
Comment thread Sources/NextcloudFileProviderKit/Item/Item.swift
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 99.77629% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.61%. Comparing base (36ba86a) to head (9d24b70).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
Sources/NextcloudFileProviderKit/Item/Item.swift 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   83.00%   83.61%   +0.60%     
==========================================
  Files          70       70              
  Lines       14924    15337     +413     
==========================================
+ Hits        12388    12824     +436     
+ Misses       2536     2513      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra merged commit 41168e0 into main Jun 6, 2025
3 checks passed
@claucambra claucambra deleted the bugfix/capabilities branch June 6, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants