Further pagination-related fixes#88
Merged
Merged
Conversation
… after server url read Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces further pagination-related fixes by adjusting test mocks, enhancing logging, and refining URL matching logic during enumeration.
- Updated the root container mock name in tests
- Added OSLog-based debug/info logging in pagination response and enumerator
- Refined root URL matching conditions in the sync engine and augmented database logging
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Interface/MockRemoteItem.swift | Changed root container mock name from empty string to "." |
| Sources/NextcloudFileProviderKit/Enumeration/EnumeratorPageResponse.swift | Imported OSLog and added debug logs around pagination header parsing |
| Sources/NextcloudFileProviderKit/Enumeration/Enumerator.swift | Enhanced debug/info logs for page payload and pagination flow |
| Sources/NextcloudFileProviderKit/Enumeration/Enumerator+SyncEngine.swift | Expanded and corrected URL matching conditions during initial sync enumeration |
| Sources/NextcloudFileProviderKit/Database/FilesDatabaseManager.swift | Added directory flag to logged metadata |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 83.82% 83.84% +0.01%
==========================================
Files 70 70
Lines 15553 15599 +46
==========================================
+ Hits 13038 13079 +41
- Misses 2515 2520 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.