Skip to content

Further pagination-related fixes#88

Merged
claucambra merged 13 commits into
mainfrom
bugfix/pagination-pt4
Jun 10, 2025
Merged

Further pagination-related fixes#88
claucambra merged 13 commits into
mainfrom
bugfix/pagination-pt4

Conversation

@claucambra
Copy link
Copy Markdown
Contributor

No description provided.

claucambra added 12 commits June 9, 2025 16:01
… after server url read

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra added this to the 3.0 milestone Jun 10, 2025
@claucambra claucambra requested a review from Copilot June 10, 2025 02:40
@claucambra claucambra self-assigned this Jun 10, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces further pagination-related fixes by adjusting test mocks, enhancing logging, and refining URL matching logic during enumeration.

  • Updated the root container mock name in tests
  • Added OSLog-based debug/info logging in pagination response and enumerator
  • Refined root URL matching conditions in the sync engine and augmented database logging

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Tests/Interface/MockRemoteItem.swift Changed root container mock name from empty string to "."
Sources/NextcloudFileProviderKit/Enumeration/EnumeratorPageResponse.swift Imported OSLog and added debug logs around pagination header parsing
Sources/NextcloudFileProviderKit/Enumeration/Enumerator.swift Enhanced debug/info logs for page payload and pagination flow
Sources/NextcloudFileProviderKit/Enumeration/Enumerator+SyncEngine.swift Expanded and corrected URL matching conditions during initial sync enumeration
Sources/NextcloudFileProviderKit/Database/FilesDatabaseManager.swift Added directory flag to logged metadata

Comment thread Sources/NextcloudFileProviderKit/Enumeration/EnumeratorPageResponse.swift Outdated
Comment thread Sources/NextcloudFileProviderKit/Enumeration/Enumerator.swift
Comment thread Sources/NextcloudFileProviderKit/Enumeration/Enumerator.swift
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (9a0a733) to head (5884db8).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...roviderKit/Enumeration/Enumerator+SyncEngine.swift 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   83.82%   83.84%   +0.01%     
==========================================
  Files          70       70              
  Lines       15553    15599      +46     
==========================================
+ Hits        13038    13079      +41     
- Misses       2515     2520       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra merged commit afd311e into main Jun 10, 2025
3 checks passed
@claucambra claucambra deleted the bugfix/pagination-pt4 branch June 10, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants