fix: saveInitial set to true in case of the capabilities

Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>

Author: enjeck

lib/AppInfo/Capabilities.php

@@ -26,7 +26,7 @@ public function getCapabilities(): array {
 			Application::APP_ID => [
 				'api_version' => Application::$API_VERSIONS,
 				'version' => $this->appManager->getAppVersion(Application::APP_ID),
-				'notes_path' => $this->userId !== null && $this->userId !== ' ' ? $this->noteUtil->getNotesFolderUserPath($this->userId) : null,
+				'notes_path' => $this->userId !== null && $this->userId !== ' ' ? $this->noteUtil->getNotesFolderUserPath($this->userId, true) : null,
 			],
 		];
 	}

lib/Service/NoteUtil.php

@@ -183,9 +183,9 @@ public function getOrCreateFolder(string $path, bool $create = true) : Folder {
 		return $folder;
 	}
 
-	public function getNotesFolderUserPath(string $userId): ?string {
+	public function getNotesFolderUserPath(string $userId, bool $saveInitial = false): ?string {
 		try {
-			$notesFolder = $this->settingsService->get($userId, 'notesPath');
+			$notesFolder = $this->settingsService->get($userId, 'notesPath', $saveInitial);
 			return $notesFolder;
 		} catch (NotesFolderException $e) {
 			$this->util->logger->debug("Failed to get notes folder for user $userId: " . $e->getMessage());

lib/Service/SettingsService.php

@@ -152,22 +152,18 @@ public function getAll(string $uid, $saveInitial = false) : \stdClass {
 		$settings = $this->getSettingsFromDB($uid);
 		// use default for empty settings
 		$toBeSaved = false;
-		$toSaveNotesPath = false;
 		foreach ($this->attrs as $name => $attr) {
 			if (!property_exists($settings, $name)) {
 				$defaultValue = $attr['default'];
 				if (is_callable($defaultValue)) {
 					$settings->{$name} = $defaultValue($uid);
 					$toBeSaved = $saveInitial;
-					if ($name === 'notesPath') {
-						$toSaveNotesPath = true;
-					}
 				} else {
 					$settings->{$name} = $defaultValue;
 				}
 			}
 		}
-		if ($toSaveNotesPath || $toBeSaved) {
+		if ($toBeSaved) {
 			$this->set($uid, (array)$settings);
 		}
 		return $settings;
@@ -176,8 +172,8 @@ public function getAll(string $uid, $saveInitial = false) : \stdClass {
 	/**
 	 * @throws \OCP\PreConditionNotMetException
 	 */
-	public function get(string $uid, string $name) : string {
-		$settings = $this->getAll($uid);
+	public function get(string $uid, string $name, bool $saveInitial = false) : string {
+		$settings = $this->getAll($uid, $saveInitial);
 		if (property_exists($settings, $name)) {
 			return $settings->{$name};
 		} else {