Merge pull request #1743 from nextcloud/carl/perf-getbyid

perf: Replace getById call with getFistNodeByid

Author: enjeck

appinfo/info.xml

@@ -25,8 +25,8 @@ The Notes app is a distraction free notes taking app for [Nextcloud](https://www
 	<repository type="git">https://github.com/nextcloud/notes.git</repository>
 	<screenshot small-thumbnail="https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Notes/notes-thumbnail.jpg">https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Notes/notes.png</screenshot>
 	<dependencies>
-		<php min-version="8.0" max-version="8.4"/>
-		<nextcloud min-version="28" max-version="34"/>
+		<php min-version="8.1" max-version="8.4"/>
+		<nextcloud min-version="30" max-version="34"/>
 	</dependencies>
 	<repair-steps>
 		<post-migration>

lib/Service/NotesService.php

@@ -290,12 +290,12 @@ private function getCustomExtension(string $userId) {
 	 * @throws NoteDoesNotExistException
 	 */
 	private static function getFileById(string $customExtension, Folder $folder, int $id) : File {
-		$file = $folder->getById($id);
+		$file = $folder->getFirstNodeById($id);
 
-		if (!array_key_exists(0, $file) || !($file[0] instanceof File) || !self::isNote($file[0], $customExtension)) {
+		if (!($file instanceof File) || !self::isNote($file, $customExtension)) {
 			throw new NoteDoesNotExistException();
 		}
-		return $file[0];
+		return $file;
 	}
 
 	/**

psalm.xml

@@ -5,7 +5,7 @@
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
     errorBaseline="tests/psalm-baseline.xml"
-    phpVersion="8.0"
+    phpVersion="8.1"
 >
 	<stubs>
 		<file name="tests/stubs/ocp.php" preloadClasses="true"/>