Update PHP max version to 8.5 in info.xml#1813
Conversation
There was a problem hiding this comment.
to resolve the failing CI https://github.com/nextcloud/notes/actions/runs/24134072818/job/70417547051?pr=1813, can you ammend your commit message? Maybe prefix it with "fix: " or "chore: "
Signed-off-by: Holger Hees <holger.hees@gmail.com>
HolgerHees
force-pushed
the
HolgerHees-nextcloud-patch-1
branch
from
10fa67c to
b69b2fe
Compare
done |
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Separately I wonder if we really need to keep v28 / 8.0 supported here, but don't let that hold this up.
updated to 30/8.1 in another PR. Ideally should be on 32+, but don't wanna make such a big jump suddenly |
Signed-off-by: Enjeck <32180937+enjeck@users.noreply.github.com>
enjeck
force-pushed
the
HolgerHees-nextcloud-patch-1
branch
from
97c0110 to
915e7db
Compare
3 participants
As nextcloud 33 support php 8.5, notes should support it too.
Current situation is, if I run nextcloud 33 with php 8.5, the latest notes version is 3.5.1, which is totally wrong.
The reason is that version 3.5.1 has a '*' as a php version string. Thats interpreted as version 3.5.1 is supporting all php versions. But version 3.5.1 is not running with nextcloud 33.
So the solution is to change the supported php version to match the one in latest nextcloud.