Merge pull request #3089 from nextcloud/backport/3088/stable34

nickvergessen · web-flow · commit e0cf0db42e1a · 2026-06-15T08:59:53.000+02:00
[stable34] fix(webpush): Don't reuse query object for second query
diff --git a/lib/Controller/WebPushController.php b/lib/Controller/WebPushController.php
@@ -298,6 +298,8 @@ protected function activateSubscription(IUser $user, IToken|ISession $token, str
 		if ($row['activated']) {
 			return ActivationSubStatus::OK;
 		}
+
+		$query = $this->db->getQueryBuilder();
 		$query->update('notifications_webpush')
 			->set('activated', $query->createNamedParameter(true))
 			->where($query->expr()->eq('uid', $query->createNamedParameter($user->getUID())))

Original file line number	Diff line number	Diff line change
`@@ -298,6 +298,8 @@ protected function activateSubscription(IUser $user, IToken\|ISession $token, str`
`298`	`298`	`if ($row['activated']) {`
`299`	`299`	`return ActivationSubStatus::OK;`
`300`	`300`	`}`
	`301`	`+`
	`302`	`+ $query = $this->db->getQueryBuilder();`
`301`	`303`	`$query->update('notifications_webpush')`
`302`	`304`	`->set('activated', $query->createNamedParameter(true))`
`303`	`305`	`->where($query->expr()->eq('uid', $query->createNamedParameter($user->getUID())))`