Relax ProtectSystem recommendation in readme#719
Conversation
Now, this is currently not required for notify_push functionality to the best of my knowledge. However, in case notify_push would somehow write to the nextcloud files in the future, it won't hurt to account for that case, as full system protection should be good enough for what we're aiming for. See nextcloud/documentation#15079 (comment) Signed-off-by: Łukasz Domeradzki <JustArchi@JustArchi.net>
|
I don't see a case where the push daemon will ever need write access to the nextcloud files. We also support running the daemon on a different host, which would be incompatible with that also. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
Now, this is currently not required for notify_push functionality to the best of my knowledge. However, in case notify_push would somehow write to the nextcloud files in the future, it won't hurt to account for that case, as full system protection should be good enough for what we're aiming for.
See nextcloud/documentation#15079 (comment)