Skip to content

Commit 9c30063

Browse files
authored
Merge pull request #4203 from nextcloud/fix/activities
Fix loading activities
2 parents 5335a67 + 5565c7c commit 9c30063

2 files changed

Lines changed: 12 additions & 7 deletions

File tree

src/components/Activity/ActivityItem.vue

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<script setup lang="ts">
77
import { computed } from 'vue'
8-
import moment from '@nextcloud/moment'
8+
import { DateTime } from 'luxon'
99
1010
import NcUserBubble from '@nextcloud/vue/components/NcUserBubble'
1111
import NcRichText from '@nextcloud/vue/components/NcRichText'
@@ -20,7 +20,7 @@ const props = defineProps({
2020
})
2121
2222
const dateActivityRelative = computed(() =>
23-
moment(props.activity.datetime).fromNow(),
23+
DateTime.fromISO(props.activity.datetime).toRelative(),
2424
)
2525
2626
const message = computed(() => {
@@ -32,7 +32,9 @@ const message = computed(() => {
3232
&& parameters.after.id.startsWith('dt:')
3333
) {
3434
const dateTime = parameters.after.id.slice(3)
35-
parameters.after.name = moment(dateTime).format('L LTS')
35+
parameters.after.name = DateTime.fromISO(dateTime).toLocaleString(
36+
DateTime.DATETIME_SHORT,
37+
)
3638
}
3739
3840
Object.keys(parameters).forEach(function (key) {

src/components/SideBar/SideBarTabActivity.vue

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,14 @@
66
<script setup lang="ts">
77
import { computed, onMounted, onUnmounted } from 'vue'
88
import { t } from '@nextcloud/l10n'
9-
import { subscribe, unsubscribe } from '@nextcloud/event-bus'
109
1110
import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
1211
1312
import ActivityIcon from 'vue-material-design-icons/LightningBolt.vue'
1413
1514
import Activities from '../Activity/Activities.vue'
1615
import { useActivityStore } from '../../stores/activity'
17-
import { Event } from '../../Types'
16+
import { onBeforeRouteUpdate } from 'vue-router'
1817
1918
const activityStore = useActivityStore()
2019
const emptyContentProps = {
@@ -26,11 +25,15 @@ const showEmptyContent = computed(
2625
)
2726
2827
onMounted(() => {
29-
subscribe(Event.UpdateActivity, () => activityStore.load())
28+
activityStore.load()
29+
})
30+
31+
onBeforeRouteUpdate(async () => {
32+
activityStore.load()
3033
})
3134
3235
onUnmounted(() => {
33-
unsubscribe(Event.UpdateActivity, () => activityStore.load())
36+
activityStore.$reset()
3437
})
3538
</script>
3639

0 commit comments

Comments
 (0)