Merge pull request #4360 from small1/fixsql

dartcafe · web-flow · commit b4550f08063c · 2025-10-31T15:09:08.000+01:00
Fix: ansi safe sql syntax
diff --git a/lib/Helper/SqlHelper.php b/lib/Helper/SqlHelper.php
@@ -35,7 +35,7 @@ public static function getConcatenatedArray(
 			IDBConnection::PLATFORM_POSTGRES => $qb->createFunction('string_agg(distinct ' . $concatColumn . '::varchar, \'' . $separator . '\') AS ' . $asColumn),
 			IDBConnection::PLATFORM_ORACLE => $qb->createFunction('listagg(distinct ' . $concatColumn . ', \'' . $separator . '\') WITHIN GROUP (ORDER BY ' . $concatColumn . ') AS ' . $asColumn),
 			IDBConnection::PLATFORM_SQLITE => $qb->createFunction('group_concat(replace(distinct ' . $concatColumn . ' ,\'\',\'\'), \'' . $separator . '\') AS ' . $asColumn),
-			default => $qb->createFunction('group_concat(distinct ' . $concatColumn . ' SEPARATOR "' . $separator . '") AS ' . $asColumn),
+			default => $qb->createFunction('group_concat(distinct ' . $concatColumn . ' SEPARATOR \'' . $separator . '\') AS ' . $asColumn),
 		});
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public static function getConcatenatedArray(`
`35`	`35`	`IDBConnection::PLATFORM_POSTGRES => $qb->createFunction('string_agg(distinct ' . $concatColumn . '::varchar, \'' . $separator . '\') AS ' . $asColumn),`
`36`	`36`	`IDBConnection::PLATFORM_ORACLE => $qb->createFunction('listagg(distinct ' . $concatColumn . ', \'' . $separator . '\') WITHIN GROUP (ORDER BY ' . $concatColumn . ') AS ' . $asColumn),`
`37`	`37`	`IDBConnection::PLATFORM_SQLITE => $qb->createFunction('group_concat(replace(distinct ' . $concatColumn . ' ,\'\',\'\'), \'' . $separator . '\') AS ' . $asColumn),`
`38`		`- default => $qb->createFunction('group_concat(distinct ' . $concatColumn . ' SEPARATOR "' . $separator . '") AS ' . $asColumn),`
	`38`	`+ default => $qb->createFunction('group_concat(distinct ' . $concatColumn . ' SEPARATOR \'' . $separator . '\') AS ' . $asColumn),`
`39`	`39`	`});`
`40`	`40`	`}`
`41`	`41`	`}`