Skip to content

Sort options by yes votes#3988

Merged
dartcafe merged 27 commits into
mainfrom
enh/sort-by-votes
Apr 29, 2025
Merged

Sort options by yes votes#3988
dartcafe merged 27 commits into
mainfrom
enh/sort-by-votes

Conversation

@dartcafe
Copy link
Copy Markdown
Collaborator

@dartcafe dartcafe commented Apr 26, 2025

Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe added this to the 8.0 milestone Apr 26, 2025
nextcloud-bot and others added 24 commits April 26, 2025 11:21
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Bumps [marked](https://github.com/markedjs/marked) from 15.0.9 to 15.0.10.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v15.0.9...v15.0.10)

Signed-off-by: dartcafe <github@dartcafe.de>

---
updated-dependencies:
- dependency-name: marked
  dependency-version: 15.0.10
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
This reverts commit c8c9adf.

Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.2 to 6.3.3.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.3.3/packages/vite)

Signed-off-by: dartcafe <github@dartcafe.de>

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 6.3.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [marked](https://github.com/markedjs/marked) from 15.0.10 to 15.0.11.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v15.0.10...v15.0.11)

Signed-off-by: dartcafe <github@dartcafe.de>

---
updated-dependencies:
- dependency-name: marked
  dependency-version: 15.0.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: René Gieling <26707476+dartcafe@users.noreply.github.com>
@dartcafe dartcafe merged commit 101e0dc into main Apr 29, 2025
47 of 49 checks passed
@Bibo-Joshi
Copy link
Copy Markdown

Hi. Very cool to see the activity for 8.x! I just wanted to clarify:

Add sorting of participants by yes-votes per option #3322

This is not what I meant in that issue with "Sort/Group Participants by selected option" 🫠
It seems that you can now sort the options such that options with a high number of yes-votes are shown first. This is ofc useful as well!
What I was aiming for however is sorting the users within an option such that the yes-voters are shown first before the maybe- & no-voters

@dartcafe
Copy link
Copy Markdown
Collaborator Author

Did you see the three dots menu? You will see a sort option:
image

@Bibo-Joshi
Copy link
Copy Markdown

Aha, it's there on polls that I created (or got transferred into my ownership?) but the three dots are not available on polls that I'm just participating in. I tested on the latter yesterday, that's why I didn't see it. Awesome that the functionality is there now 🎊 thanks a lot! My use case would still require the sorting to be available to participants. Should I report that as a separate issue or should it just be tracked as part of #3322?

@dartcafe
Copy link
Copy Markdown
Collaborator Author

Add it as another issue.
BTW: Never bundle multiple stories, they are not easy to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants