From 72639caa77589768cc82a69579197b60963c959f Mon Sep 17 00:00:00 2001
From: dartcafe <github@dartcafe.de>
Date: Sat, 21 Jun 2025 18:48:52 +0200
Subject: [PATCH] edit poll groups

Signed-off-by: dartcafe <github@dartcafe.de>
---
 lib/Controller/PollController.php             |  15 ++
 lib/Service/PollService.php                   |  21 ++
 src/Api/modules/polls.ts                      |  21 ++
 .../Actions/modules/ActionEditGroup.vue       |  57 +++++
 src/components/PollGroup/PollGroupEditDlg.vue | 200 ++++++++++++++++++
 src/stores/polls.ts                           |  53 +++--
 src/views/PollList.vue                        |   8 +
 7 files changed, 362 insertions(+), 13 deletions(-)
 create mode 100644 src/components/Actions/modules/ActionEditGroup.vue
 create mode 100644 src/components/PollGroup/PollGroupEditDlg.vue

diff --git a/lib/Controller/PollController.php b/lib/Controller/PollController.php
index f5d3a1d903..d3a29969a7 100644
--- a/lib/Controller/PollController.php
+++ b/lib/Controller/PollController.php
@@ -313,6 +313,21 @@ public function addPollToPollGroup(int $pollId, int $pollGroupId): JSONResponse
 		]);
 	}
 
+	/**
+	 * Update Pollgroup
+	 */
+	#[NoAdminRequired]
+	#[FrontpageRoute(verb: 'PUT', url: '/pollgroup/{pollGroupId}/update')]
+	public function updatePollGroup(
+		int $pollGroupId,
+		string $title,
+		string $titleExt,
+		string $description,
+	): JSONResponse {
+		return $this->response(fn () => [
+			'pollGroup' => $this->pollService->updatePollGroup($pollGroupId, $title, $titleExt, $description),
+		]);
+	}
 	/**
 	 * Remove poll from pollgroup
 	 * @param int $pollId Poll id
diff --git a/lib/Service/PollService.php b/lib/Service/PollService.php
index 92b0fbf1a6..2db1c161d0 100644
--- a/lib/Service/PollService.php
+++ b/lib/Service/PollService.php
@@ -72,6 +72,27 @@ public function listPollGroups(): array {
 		return $this->pollGroupMapper->list();
 	}
 
+	public function updatePollGroup(
+		int $pollGroupId,
+		string $title,
+		string $titleExt,
+		string $description,
+	): PollGroup {
+		try {
+			$pollGroup = $this->pollGroupMapper->find($pollGroupId);
+			if ($pollGroup->getOwner() !== $this->userSession->getCurrentUserId()) {
+				throw new ForbiddenException('You do not have permission to edit this poll group');
+			}
+			$pollGroup->setTitle($title);
+			$pollGroup->setTitleExt($titleExt);
+			$pollGroup->setDescription($description);
+
+			$pollGroup = $this->pollGroupMapper->update($pollGroup);
+			return $pollGroup;
+		} catch (DoesNotExistException $e) {
+			throw new NotFoundException('Poll group not found');
+		}
+	}
 	public function addPollToPollGroup(
 		int $pollId,
 		?int $pollGroupId = null,
diff --git a/src/Api/modules/polls.ts b/src/Api/modules/polls.ts
index 7d84a42d39..9558c18c5b 100644
--- a/src/Api/modules/polls.ts
+++ b/src/Api/modules/polls.ts
@@ -76,6 +76,27 @@ const polls = {
 		})
 	},
 
+	updatePollGroup(
+		pollGroupId: number,
+		title: string,
+		titleExt: string,
+		description: string,
+	): Promise<AxiosResponse<{ pollGroup: PollGroup }>> {
+		return httpInstance.request({
+			method: 'PUT',
+			url: `pollgroup/${pollGroupId}/update`,
+			data: {
+				title,
+				titleExt,
+				description,
+			},
+			cancelToken:
+				cancelTokenHandlerObject[
+					this.updatePollGroup.name
+				].handleRequestCancellation().token,
+		})
+	},
+
 	getPolls(): Promise<
 		AxiosResponse<{
 			polls: Poll[]
diff --git a/src/components/Actions/modules/ActionEditGroup.vue b/src/components/Actions/modules/ActionEditGroup.vue
new file mode 100644
index 0000000000..ee4bf934e3
--- /dev/null
+++ b/src/components/Actions/modules/ActionEditGroup.vue
@@ -0,0 +1,57 @@
+<!--
+  - SPDX-FileCopyrightText: 2021 Nextcloud contributors
+  - SPDX-License-Identifier: AGPL-3.0-or-later
+-->
+
+<script setup lang="ts">
+import { ref } from 'vue'
+
+import { useSessionStore } from '../../../stores/session'
+
+import { t } from '@nextcloud/l10n'
+
+import ButtonModal from '../../Base/modules/ButtonModal.vue'
+import { ButtonMode } from '../../../Types'
+import PollGroupEditDlg from '../../PollGroup/PollGroupEditDlg.vue'
+
+import EditIcon from 'vue-material-design-icons/Pencil.vue'
+
+interface Props {
+	caption?: string
+	modalSize?: string
+	buttonMode?: ButtonMode
+}
+
+const {
+	caption = t('polls', 'Edit poll group'),
+	modalSize = 'normal',
+	buttonMode = ButtonMode.Native,
+} = defineProps<Props>()
+
+const sessionStore = useSessionStore()
+
+const showModal = ref(false)
+
+function updatedGroup() {
+	// close modal and show the confirmation dialog
+	showModal.value = false
+}
+</script>
+
+<template>
+	<ButtonModal
+		v-if="sessionStore.appPermissions.pollCreation"
+		v-model:show-modal="showModal"
+		:aria-label="caption"
+		:button-caption="caption"
+		:modal-size="modalSize"
+		:button-mode="buttonMode"
+		:button-variant="'secondary'">
+		<template #icon>
+			<EditIcon size="20" decorative />
+		</template>
+		<template #modal-content>
+			<PollGroupEditDlg @updated="updatedGroup" @close="showModal = false" />
+		</template>
+	</ButtonModal>
+</template>
diff --git a/src/components/PollGroup/PollGroupEditDlg.vue b/src/components/PollGroup/PollGroupEditDlg.vue
new file mode 100644
index 0000000000..b93cdd9b16
--- /dev/null
+++ b/src/components/PollGroup/PollGroupEditDlg.vue
@@ -0,0 +1,200 @@
+<!--
+  - SPDX-FileCopyrightText: 2018 Nextcloud contributors
+  - SPDX-License-Identifier: AGPL-3.0-or-later
+-->
+
+<script setup lang="ts">
+import { computed, ref, watch } from 'vue'
+import { t } from '@nextcloud/l10n'
+
+import NcButton from '@nextcloud/vue/components/NcButton'
+
+import SpeakerIcon from 'vue-material-design-icons/Bullhorn.vue'
+import SpeakerBigIcon from 'vue-material-design-icons/BullhornVariant.vue'
+import DescriptionIcon from 'vue-material-design-icons/TextBox.vue'
+
+import { ConfigBox, InputDiv } from '../Base/index.ts'
+
+import { usePollsStore } from '../../stores/polls.ts'
+import { showError } from '@nextcloud/dialogs'
+import { useRoute } from 'vue-router'
+import { router } from '../../router.ts'
+
+const pollsStore = usePollsStore()
+const route = useRoute()
+const helperTexts = {
+	title: t('polls', 'Choose a brief title for the navigation bar and the slug'),
+	titleExt: t('polls', 'Choose a more meaningful title for the overview page'),
+	description: t('polls', 'Choose a description for the overview page'),
+	titleChangedNote: t('polls', 'Note: Changing the title, also changes the URL'),
+}
+const emit = defineEmits<{
+	(e: 'close'): void
+	(e: 'updated'): void
+}>()
+
+const newGroupAttributes = ref({
+	slug: route.params.slug as string,
+	title: pollsStore.currentGroup?.title || '',
+	titleExt: pollsStore.currentGroup?.titleExt || '',
+	description: pollsStore.currentGroup?.description || '',
+})
+
+watch(route, (route) => {
+	resetInputs(route.params.slug as string)
+})
+
+const pollGroupTitle = computed({
+	get() {
+		return pollsStore.currentGroup?.title || ''
+	},
+	set(newTitle: string) {
+		newGroupAttributes.value.title = newTitle
+	},
+})
+const pollGroupTitleExt = computed({
+	get() {
+		return pollsStore.currentGroup?.titleExt || ''
+	},
+	set(newTitleExt: string) {
+		newGroupAttributes.value.titleExt = newTitleExt
+	},
+})
+
+const pollGroupTitleDescription = computed({
+	get() {
+		return pollsStore.currentGroup?.description || ''
+	},
+	set(newDescription: string) {
+		newGroupAttributes.value.description = newDescription
+	},
+})
+
+const updating = ref(false)
+
+const titleUpdated = computed(
+	() => pollGroupTitle.value !== pollsStore.currentGroup?.title,
+)
+const titleIsEmpty = computed(() => pollGroupTitle.value === '')
+const disableEditButton = computed(() => titleIsEmpty.value || updating.value)
+
+function resetInputs(slug: string) {
+	newGroupAttributes.value = {
+		slug,
+		title: pollsStore.currentGroup?.title || '',
+		titleExt: pollsStore.currentGroup?.titleExt || '',
+		description: pollsStore.currentGroup?.description || '',
+	}
+}
+
+async function updatePollGroup() {
+	try {
+		// block the modal to prevent double submission
+		updating.value = true
+		// add the poll
+		const pollGroup = await pollsStore.updatePollGroup(newGroupAttributes.value)
+
+		if (pollGroup) {
+			resetInputs(route.params.slug as string)
+			emit('updated')
+			router.push({
+				name: 'group',
+				params: { slug: pollGroup.slug },
+			})
+		}
+	} catch {
+		showError(t('polls', 'Error updating PollGroup'))
+	} finally {
+		// unblock the modal
+		updating.value = false
+	}
+}
+</script>
+
+<template>
+	<div class="edit-poll-group">
+		<ConfigBox :name="t('polls', 'Title')">
+			<template #icon>
+				<SpeakerIcon />
+			</template>
+			<InputDiv
+				v-model="pollGroupTitle"
+				focus
+				type="text"
+				:placeholder="t('polls', 'Enter Title')"
+				:helper-text="helperTexts.title"
+				@submit="updatePollGroup" />
+
+			<div class="change-title-hint">
+				<p v-if="titleUpdated">
+					{{ helperTexts.titleChangedNote }}
+				</p>
+			</div>
+		</ConfigBox>
+
+		<ConfigBox :name="t('polls', 'Extended title')">
+			<template #icon>
+				<SpeakerBigIcon />
+			</template>
+			<InputDiv
+				v-model="pollGroupTitleExt"
+				type="text"
+				:placeholder="t('polls', 'Enter extended Title')"
+				:helper-text="helperTexts.titleExt"
+				@submit="updatePollGroup" />
+		</ConfigBox>
+
+		<ConfigBox :name="t('polls', 'Description')">
+			<template #icon>
+				<DescriptionIcon />
+			</template>
+			<textarea
+				v-model="pollGroupTitleDescription"
+				class="input-textarea"
+				:placeholder="t('polls', 'Enter a description')" />
+			<p class="helper">
+				{{ helperTexts.description }}
+			</p>
+		</ConfigBox>
+
+		<div class="create-buttons">
+			<NcButton @click="emit('close')">
+				<template #default>
+					{{ t('polls', 'Close') }}
+				</template>
+			</NcButton>
+			<NcButton
+				:disabled="disableEditButton"
+				:variant="'primary'"
+				@click="updatePollGroup">
+				<template #default>
+					{{ t('polls', 'Update') }}
+				</template>
+			</NcButton>
+		</div>
+	</div>
+</template>
+
+<style lang="scss">
+.edit-poll-group {
+	background-color: var(--color-main-background);
+	padding: 8px 20px;
+
+	.create-buttons {
+		display: flex;
+		justify-content: flex-end;
+		gap: 8px;
+	}
+
+	.input-textarea {
+		width: 99%;
+		resize: vertical;
+	}
+
+	.helper {
+		min-height: 1.5rem;
+		font-size: 0.8em;
+		opacity: 0.8;
+	}
+}
+</style>
diff --git a/src/stores/polls.ts b/src/stores/polls.ts
index 0b8e24c189..a33a741201 100644
--- a/src/stores/polls.ts
+++ b/src/stores/polls.ts
@@ -414,21 +414,16 @@ export const usePollsStore = defineStore('polls', {
 			return this.pollGroups.filter((group) => !group.pollIds.includes(pollId))
 		},
 
-		updateListElement(payload: {
-			poll: Poll | undefined
-			pollGroup: PollGroup | undefined
-		}) {
+		updatePollGroupElement(payload: { pollGroup: PollGroup; poll?: Poll }) {
+			this.pollGroups = this.pollGroups
+				.filter((g) => g.id !== payload.pollGroup.id)
+				.concat(payload.pollGroup)
+
 			if (payload.poll) {
 				this.polls = this.polls
 					.filter((p) => p.id !== payload.poll?.id)
 					.concat(payload.poll)
 			}
-
-			if (payload.pollGroup) {
-				this.pollGroups = this.pollGroups
-					.filter((g) => g.id !== payload.pollGroup?.id)
-					.concat(payload.pollGroup)
-			}
 		},
 
 		async addPollToPollGroup(payload: {
@@ -442,7 +437,7 @@ export const usePollsStore = defineStore('polls', {
 						payload.pollGroupId,
 						payload.pollId,
 					)
-					this.updateListElement({
+					this.updatePollGroupElement({
 						poll: response.data.poll,
 						pollGroup: response.data.pollGroup,
 					})
@@ -454,7 +449,7 @@ export const usePollsStore = defineStore('polls', {
 						payload.groupTitle,
 						payload.pollId,
 					)
-					this.updateListElement({
+					this.updatePollGroupElement({
 						poll: response.data.poll,
 						pollGroup: response.data.pollGroup,
 					})
@@ -488,7 +483,7 @@ export const usePollsStore = defineStore('polls', {
 				}
 
 				// update the collections
-				this.updateListElement({
+				this.updatePollGroupElement({
 					poll: response.data.poll,
 					pollGroup: response.data.pollGroup,
 				})
@@ -606,5 +601,37 @@ export const usePollsStore = defineStore('polls', {
 			}
 			return t('polls', 'Invalid Group ID')
 		},
+
+		async updatePollGroup(payload: {
+			title: string
+			titleExt: string
+			description: string
+			slug: string
+		}) {
+			if (!this.currentGroup) {
+				throw new Error('No current poll group set')
+			}
+			try {
+				const response = await PollsAPI.updatePollGroup(
+					this.currentGroup.id,
+					payload.title,
+					payload.titleExt,
+					payload.description,
+				)
+				this.updatePollGroupElement({
+					pollGroup: response.data.pollGroup,
+				})
+				return response.data.pollGroup
+			} catch (error) {
+				if ((error as AxiosError)?.code === 'ERR_CANCELED') {
+					return
+				}
+				Logger.error('Error updating poll group', {
+					error,
+					payload,
+				})
+				throw error
+			}
+		},
 	},
 })
diff --git a/src/views/PollList.vue b/src/views/PollList.vue
index 8d894b77f8..81a93254e8 100644
--- a/src/views/PollList.vue
+++ b/src/views/PollList.vue
@@ -23,6 +23,7 @@ import PollItemActions from '../components/PollList/PollItemActions.vue'
 import ActionAddPoll from '../components/Actions/modules/ActionAddPoll.vue'
 import { usePreferencesStore } from '../stores/preferences.ts'
 import { useSessionStore } from '../stores/session.ts'
+import ActionEditGroup from '../components/Actions/modules/ActionEditGroup.vue'
 
 const pollsStore = usePollsStore()
 const preferencesStore = usePreferencesStore()
@@ -30,6 +31,12 @@ const sessionStore = useSessionStore()
 const router = useRouter()
 const route = useRoute()
 
+const editable = computed(
+	() =>
+		route.name === 'group'
+		&& sessionStore.currentUser.id === pollsStore.currentGroup?.owner.id,
+)
+
 const title = computed(() => {
 	if (route.name === 'group') {
 		return (
@@ -148,6 +155,7 @@ async function loadMore() {
 			</template>
 			{{ description }}
 			<template #right>
+				<ActionEditGroup v-if="editable" />
 				<ActionAddPoll v-if="preferencesStore.user.useNewPollInPollist" />
 				<PollListSort />
 			</template>