Skip to content

async store loads #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dartcafe merged 1 commit into from
Jul 27, 2025
Merged

async store loads #4188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions lib/Controller/PublicController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,6 @@ public function getPoll(): JSONResponse {
return $this->response(function () {
return [
'poll' => $this->pollService->get($this->userSession->getShare()->getPollId()),
'options' => $this->optionService->list($this->userSession->getShare()->getPollId()),
'votes' => $this->voteService->list($this->userSession->getShare()->getPollId()),
'orphaned' => 0,
'comments' => $this->commentService->list($this->userSession->getShare()->getPollId()),
'shares' => $this->shareService->list($this->userSession->getShare()->getPollId()),
'subscribed' => $this->subscriptionService->get($this->userSession->getShare()->getPollId()),
];
});
}
Expand Down
19 changes: 9 additions & 10 deletions src/stores/poll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,24 +384,23 @@ export const usePollStore = defineStore('poll', {
return PublicAPI.getPoll(sessionStore.route.params.token)
}
if (sessionStore.route.name === 'vote') {
return PollsAPI.getFullPoll(
pollId ?? sessionStore.currentPollId,
)
return PollsAPI.getPoll(pollId ?? sessionStore.currentPollId)
}
return null
})()

if (!response) {
this.$reset()
return
}

this.$patch(response.data.poll)
votesStore.votes = response.data.votes
optionsStore.options = response.data.options
sharesStore.shares = response.data.shares
commentsStore.comments = response.data.comments
subscriptionStore.subscribed = response.data.subscribed
await Promise.all([
this.$patch(response.data.poll),
votesStore.load(),
optionsStore.load(),
sharesStore.load(),
commentsStore.load(),
subscriptionStore.load(),
])

this.meta.status = 'loaded'
} catch (error) {
Expand Down