Skip to content

intercept dates of daylight saving changes #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dartcafe merged 1 commit into from
Sep 4, 2025
Merged

intercept dates of daylight saving changes #4276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/components/Base/modules/DateBox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,19 @@ const allDay = computed(
// 'to' is 'from' plus the duration
// subtract a day if allDay is true and luxonDuration is greater than 0 to match the
// end of the day after the duration instead of the beginning of the next day
const to = computed(() =>
dateTime
const to = computed(() => {
// this is a quick fix which intercepts dayspans crossing daylight saving time changes
// Adding duration as seconds divided by a normal dayspan in seconds (86400) multiplied
// by 86400 ensures that we always land at the same time of day, even if the actual
// dayspan is 23 or 25 hours due to DST changes
// FIXME: this should be replaced by a more stable solution
if (allDay.value) {
return dateTime.plus((duration.as('seconds') / 86400) * 86400)
}
return dateTime
.plus(duration)
.minus({ day: allDay.value && duration.as('seconds') > 0 ? 1 : 0 }),
)
.minus({ day: allDay.value && duration.as('seconds') > 0 ? 1 : 0 })
})

// to and from dates have the same month (and year)
// suppress the 'to' month if they are the same
Expand Down