fix: Rename sidebar-share css class#4297
Closed
CarlSchwan wants to merge 1 commit into
Closed
Conversation
.sidebar-share is unfortunately a pretty usual class for ads so it's blocklisted in ublock origin cosmetic lists. Rename it to polls-sidebar-share instead. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
Collaborator
|
I am truly happy for your effort by helping to get rid of a problem users have. But in this particular case, I will reject the PR. The reasons can be found in my comment. |
13 tasks
|
I really do not understand why you are refusing change something that solves the problem of a number of your users - especially when all the heavy lifting is already done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.sidebar-share is unfortunately a pretty usual class for ads so it's blocklisted in ublock origin cosmetic lists. Rename it to polls-sidebar-share instead.
Fix #4292