From 981bab3fe46e09dc8adb9233d03fb46eec7627f7 Mon Sep 17 00:00:00 2001 From: dartcafe Date: Sat, 13 Sep 2025 17:33:48 +0200 Subject: [PATCH 1/9] reduce dom depth for sidebar Signed-off-by: dartcafe --- src/components/SideBar/SideBarTabActivity.vue | 14 +-- src/components/SideBar/SideBarTabComments.vue | 48 ++++---- .../SideBar/SideBarTabConfiguration.vue | 114 +++++++++-------- .../SideBar/SideBarTabDatePolls.vue | 18 ++- src/components/SideBar/SideBarTabOptions.vue | 116 +++++++++--------- src/components/SideBar/SideBarTabShare.vue | 19 +-- .../SideBar/SideBarTabSharePollGroup.vue | 18 +-- 7 files changed, 156 insertions(+), 191 deletions(-) diff --git a/src/components/SideBar/SideBarTabActivity.vue b/src/components/SideBar/SideBarTabActivity.vue index 0225d8b6bb..f2565f7520 100644 --- a/src/components/SideBar/SideBarTabActivity.vue +++ b/src/components/SideBar/SideBarTabActivity.vue @@ -38,12 +38,10 @@ onUnmounted(() => { diff --git a/src/components/SideBar/SideBarTabComments.vue b/src/components/SideBar/SideBarTabComments.vue index b28abcd451..cc9d53c2d2 100644 --- a/src/components/SideBar/SideBarTabComments.vue +++ b/src/components/SideBar/SideBarTabComments.vue @@ -53,31 +53,27 @@ watch( diff --git a/src/components/SideBar/SideBarTabConfiguration.vue b/src/components/SideBar/SideBarTabConfiguration.vue index 6820076b90..5fa005110f 100644 --- a/src/components/SideBar/SideBarTabConfiguration.vue +++ b/src/components/SideBar/SideBarTabConfiguration.vue @@ -38,71 +38,67 @@ const votesStore = useVotesStore() diff --git a/src/components/SideBar/SideBarTabDatePolls.vue b/src/components/SideBar/SideBarTabDatePolls.vue index f733d869d7..4363169ecd 100644 --- a/src/components/SideBar/SideBarTabDatePolls.vue +++ b/src/components/SideBar/SideBarTabDatePolls.vue @@ -14,16 +14,14 @@ const comboStore = useComboStore() diff --git a/src/components/SideBar/SideBarTabOptions.vue b/src/components/SideBar/SideBarTabOptions.vue index bcdf422b38..01cbe1c6af 100644 --- a/src/components/SideBar/SideBarTabOptions.vue +++ b/src/components/SideBar/SideBarTabOptions.vue @@ -57,67 +57,65 @@ onUnmounted(() => { diff --git a/src/components/SideBar/SideBarTabShare.vue b/src/components/SideBar/SideBarTabShare.vue index 1771dd3da7..a319385757 100644 --- a/src/components/SideBar/SideBarTabShare.vue +++ b/src/components/SideBar/SideBarTabShare.vue @@ -31,23 +31,14 @@ onBeforeRouteLeave(() => { diff --git a/src/components/Shares/SharesListLocked.vue b/src/components/Shares/SharesListLocked.vue index dfe71dfad1..2e91bff7da 100644 --- a/src/components/Shares/SharesListLocked.vue +++ b/src/components/Shares/SharesListLocked.vue @@ -24,10 +24,11 @@ const configBoxProps = { - + diff --git a/src/components/Shares/SharesListPollGroup.vue b/src/components/Shares/SharesListPollGroup.vue index 289e2a8853..411cd58933 100644 --- a/src/components/Shares/SharesListPollGroup.vue +++ b/src/components/Shares/SharesListPollGroup.vue @@ -49,14 +49,15 @@ async function addShare(user: User) { :search-types="[0]" @user-selected="(user: User) => addShare(user)" /> -
- + diff --git a/src/components/Shares/SharesListUnsent.vue b/src/components/Shares/SharesListUnsent.vue index c86f140030..f5b43b2235 100644 --- a/src/components/Shares/SharesListUnsent.vue +++ b/src/components/Shares/SharesListUnsent.vue @@ -72,10 +72,11 @@ async function sendAllInvitations() { - + diff --git a/src/components/SideBar/SideBarTabShare.vue b/src/components/SideBar/SideBarTabShare.vue index a319385757..04951a45c7 100644 --- a/src/components/SideBar/SideBarTabShare.vue +++ b/src/components/SideBar/SideBarTabShare.vue @@ -31,41 +31,7 @@ onBeforeRouteLeave(() => { - - diff --git a/src/components/SideBar/SideBarTabSharePollGroup.vue b/src/components/SideBar/SideBarTabSharePollGroup.vue index 88f1684744..e4583c9a2c 100644 --- a/src/components/SideBar/SideBarTabSharePollGroup.vue +++ b/src/components/SideBar/SideBarTabSharePollGroup.vue @@ -31,37 +31,5 @@ onBeforeRouteUpdate(async () => {
{{ infoText }}
- + - - diff --git a/src/components/User/UserItem.vue b/src/components/User/UserItem.vue index dbb7fdf8a4..2c08888b76 100644 --- a/src/components/User/UserItem.vue +++ b/src/components/User/UserItem.vue @@ -40,6 +40,7 @@ interface Props { description?: string label?: string type?: UserType | VirtualUserItemType + tag?: string user?: User showTypeIcon?: boolean iconSize?: number @@ -61,6 +62,7 @@ const { resolveInfo = false, description, label = '', + tag = 'div', type = '', user = { id: '', @@ -212,7 +214,7 @@ function showMenu() { } const componentClass = computed(() => [ 'user-item', - typeComputed, + typeComputed.value, { disabled, condensed, @@ -221,7 +223,7 @@ const componentClass = computed(() => [ diff --git a/src/components/Base/modules/InputDiv.vue b/src/components/Base/modules/InputDiv.vue index 20519d4cb0..2a3400efbc 100644 --- a/src/components/Base/modules/InputDiv.vue +++ b/src/components/Base/modules/InputDiv.vue @@ -285,11 +285,11 @@ const inputClass = computed(() => [ } &.error { - border-color: var(--color-error); + border-color: var(--color-border-error); } &.success { - border-color: var(--color-success); + border-color: var(--color-border-success); } } diff --git a/src/components/Base/modules/StickyDiv.vue b/src/components/Base/modules/StickyDiv.vue index f3e8b7d331..6f054e3d67 100644 --- a/src/components/Base/modules/StickyDiv.vue +++ b/src/components/Base/modules/StickyDiv.vue @@ -63,19 +63,17 @@ const stickyClass = computed(() => ({
-
- -
-
-
-
- -
+
+
+ +
+
+
diff --git a/src/components/Calendar/CalendarInfo.vue b/src/components/Calendar/CalendarInfo.vue index 9e2737f30e..f30f5e9e5f 100644 --- a/src/components/Calendar/CalendarInfo.vue +++ b/src/components/Calendar/CalendarInfo.vue @@ -122,7 +122,7 @@ const conflictLevel = computed(() => { } &.conflict-no { - border-inline-start: 4px solid var(--color-success); + border-inline-start: 4px solid var(--color-border-success); } &.cancelled { diff --git a/src/components/Options/OptionItem.vue b/src/components/Options/OptionItem.vue index f830e4770d..24603ad864 100644 --- a/src/components/Options/OptionItem.vue +++ b/src/components/Options/OptionItem.vue @@ -76,7 +76,7 @@ const pollStore = usePollStore() .confirmed & { background-color: var(--color-polls-background-yes); border-radius: var(--border-radius-container); - border: 2px solid var(--color-success-text); + border: 2px solid var(--color-border-success); } .list-view .confirmed & { diff --git a/src/components/Poll/PollInfoLine.vue b/src/components/Poll/PollInfoLine.vue index 49912f6875..596dfa96d2 100644 --- a/src/components/Poll/PollInfoLine.vue +++ b/src/components/Poll/PollInfoLine.vue @@ -181,7 +181,7 @@ const timeExpirationRelative = computed(() => { .closed, .archived { .sub-text { - color: var(--color-error); + color: var(--color-error-text); font-weight: 700; } } diff --git a/src/components/PollList/PollItem.vue b/src/components/PollList/PollItem.vue index 7e86e15c77..76e1896da7 100644 --- a/src/components/PollList/PollItem.vue +++ b/src/components/PollList/PollItem.vue @@ -243,7 +243,7 @@ const descriptionLine = computed(() => { diff --git a/src/components/VoteTable/VoteTable.vue b/src/components/VoteTable/VoteTable.vue index 3cf396e397..fefe9326f5 100644 --- a/src/components/VoteTable/VoteTable.vue +++ b/src/components/VoteTable/VoteTable.vue @@ -139,7 +139,6 @@ function isVotable(participant: User, option: Option) {
div { + border-inline-start: 1px solid var(--color-border); + } .vote-cell { padding: 0.4rem; display: flex; @@ -201,7 +202,7 @@ function isVotable(participant: User, option: Option) { .participant { grid-column: 1; - padding: 0.8rem 0.1rem 0.1rem 0.1rem; + place-self: center; inset-inline-start: 0; background-color: var(--color-main-background); @@ -209,11 +210,6 @@ function isVotable(participant: User, option: Option) { visibility: hidden; } - &.sticky-left { - inset-inline-start: -8px; - padding-inline-start: 8px; - } - &:hover { background: var(--color-background-hover); @@ -267,7 +263,6 @@ function isVotable(participant: User, option: Option) { .option-menu-grid { grid-row: 1; - border-inline-start: 1px solid var(--color-border); background-color: var(--color-main-background); .calendar-peek { @@ -277,28 +272,21 @@ function isVotable(participant: User, option: Option) { .option-item { grid-row: 2; - border-inline-start: 1px solid var(--color-border); } .counter { grid-row: 3; - border-inline-start: 1px solid var(--color-border); - } - - .vote-cell { - border-inline-start: 1px solid var(--color-border); } > .current-user { - margin-top: 1.5rem; - margin-bottom: 1.5rem; + padding-top: 1.5rem; + padding-bottom: 1.5rem; } .vote-column { display: flex; flex-direction: column; flex: 1 0 11rem; - border-inline-start: 1px solid var(--color-border-dark); } } From bb13e74659d862f4864012ddba95e71b7e01e2b0 Mon Sep 17 00:00:00 2001 From: dartcafe Date: Sun, 14 Sep 2025 21:27:26 +0200 Subject: [PATCH 9/9] fix Signed-off-by: dartcafe --- src/components/Base/modules/StickyDiv.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Base/modules/StickyDiv.vue b/src/components/Base/modules/StickyDiv.vue index 6f054e3d67..30bd36b80d 100644 --- a/src/components/Base/modules/StickyDiv.vue +++ b/src/components/Base/modules/StickyDiv.vue @@ -64,7 +64,7 @@ const stickyClass = computed(() => ({
-
+