Replace the registration modal by a registration page#4568
Merged
Conversation
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation hat some UX flaws.
Overall, it was a 'not that good UX'. One result probably was something like this.
Therefore the modal got removed and was replaced with a registration view. The registration dialog shows a brief overview of the poll (title, description, available options) and focuses on the registration. The login option acts more as a footnote for internal users, who are currently logged out. The legal links now reside inside the footer area, if available.
The design is presented as a 'glassy presentation'. Tell me what you think.
The description and the options are expandable to a modal to make the full information accessible.
Logged in users get directed to the poll directly (or after logging in). If an external user, who already registered before and has stored a cookie to the poll, uses the public poll, he will still get redirected to the vote page as before.
After registration the user gets redirected to the vote page.