fix(QueueMapper): Do not mutate queueItem

This prevents the looping on landmarks photos

fixes #1133

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Author: marcelklehr

lib/Db/QueueMapper.php

@@ -133,8 +133,9 @@ public function insertIntoQueue(string $model, QueueFile $file) : QueueFile {
 				'update' => $qb->createPositionalParameter($file->getUpdate(), IQueryBuilder::PARAM_BOOL)
 			])
 			->executeStatement();
-		$file->setId($qb->getLastInsertId());
-		return $file;
+		$insertedFile = clone $file;
+		$insertedFile->setId($qb->getLastInsertId());
+		return $insertedFile;
 	}
 
 	public function clearQueue(string $model): void {

tests/ClassifierTest.php

@@ -446,6 +446,10 @@ public function testLandmarksPipeline() : void {
 		list($classifier, ) = $this->jobList->getJobs(ClassifyImagenetJob::class, 1, 0);
 		$classifier->start($this->jobList);
 
+		self::assertCount(0,
+			$this->queue->getFromQueue(ImagenetClassifier::MODEL_NAME, $storageId, $rootId, 100),
+			'imagenet queue should be empty after classifying an image that is forwarded to landmarks');
+
 		self::assertTrue($this->jobList->has(ClassifyLandmarksJob::class, [
 			'storageId' => $storageId,
 			'rootId' => $rootId