Merge pull request #4846 from nextcloud/backport/4807/stable30

[stable30] fix: allow document creation only for users that can edit

Author: elzody

lib/Listener/RegisterTemplateFileCreatorListener.php

@@ -34,7 +34,7 @@ public function handle(Event $event): void {
 			return;
 		}
 
-		if (!$this->permissionManager->isEnabledForUser() || empty($this->capabilitiesService->getCapabilities())) {
+		if (!$this->permissionManager->isEnabledForUser() || !$this->permissionManager->userCanEdit() || empty($this->capabilitiesService->getCapabilities())) {
 			return;
 		}
 

tests/lib/Listener/RegisterTemplateFileCreatorListenerTest.php

@@ -53,6 +53,7 @@ public function testHandleDoesNotRegisterIfPermissionOrCapabilitiesMissing() {
 		$event = $this->createMock(RegisterTemplateCreatorEvent::class);
 		$event->method('getTemplateManager')->willReturn($this->templateManager);
 		$this->permissionManager->method('isEnabledForUser')->willReturn(false);
+		$this->permissionManager->method('userCanEdit')->willReturn(true);
 		$this->capabilitiesService->method('getCapabilities')->willReturn([]);
 
 		$listener = new RegisterTemplateFileCreatorListener(
@@ -70,6 +71,7 @@ public function testHandleRegistersTemplateFileCreators() {
 		$event = $this->createMock(RegisterTemplateCreatorEvent::class);
 		$event->method('getTemplateManager')->willReturn($this->templateManager);
 		$this->permissionManager->method('isEnabledForUser')->willReturn(true);
+		$this->permissionManager->method('userCanEdit')->willReturn(true);
 		$this->capabilitiesService->method('getCapabilities')->willReturn(['something']);
 		$this->capabilitiesService->method('hasDrawSupport')->willReturn(true);
 		$this->config->method('getAppValue')->willReturn('ooxml');
@@ -91,6 +93,7 @@ public function testHandleRegistersWithoutDrawSupport() {
 		$event = $this->createMock(RegisterTemplateCreatorEvent::class);
 		$event->method('getTemplateManager')->willReturn($this->templateManager);
 		$this->permissionManager->method('isEnabledForUser')->willReturn(true);
+		$this->permissionManager->method('userCanEdit')->willReturn(true);
 		$this->capabilitiesService->method('getCapabilities')->willReturn(['something']);
 		$this->capabilitiesService->method('hasDrawSupport')->willReturn(false);
 		$this->config->method('getAppValue')->willReturn('ooxml');
@@ -107,4 +110,22 @@ public function testHandleRegistersWithoutDrawSupport() {
 		);
 		$listener->handle($event);
 	}
+
+	public function testHandleDoesNotRegisterIfUserCannotEdit() {
+		$event = $this->createMock(RegisterTemplateCreatorEvent::class);
+		$event->method('getTemplateManager')->willReturn($this->templateManager);
+		$this->permissionManager->method('isEnabledForUser')->willReturn(true);
+		$this->permissionManager->method('userCanEdit')->willReturn(false);
+		$this->capabilitiesService->method('getCapabilities')->willReturn(['something']);
+
+		$listener = new RegisterTemplateFileCreatorListener(
+			$this->l10n,
+			$this->config,
+			$this->appManager,
+			$this->capabilitiesService,
+			$this->permissionManager
+		);
+		$this->templateManager->expects($this->never())->method('registerTemplateFileCreator');
+		$listener->handle($event);
+	}
 }