Skip to content

Commit 1edcd69

Browse files
elzodybackportbot[bot]
authored andcommitted
fix(shares): guest users inherit edit_group
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> [skip ci]
1 parent 5693ce7 commit 1edcd69

3 files changed

Lines changed: 10 additions & 1 deletion

File tree

lib/Listener/ShareLinkListener.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,11 @@ public function handle(Event $event): void {
5959
$loggedInUser = $this->permissionManager->loggedInUser();
6060

6161
if ($this->permissionManager->isEnabledForUser($owner)) {
62+
$updatable = (bool)($share->getPermissions() & \OCP\Constants::PERMISSION_UPDATE);
63+
$updatable = $updatable && $this->permissionManager->userCanEdit($owner);
64+
6265
$this->initialStateService->prepareParams(['userId' => $loggedInUser]);
63-
$this->initialStateService->provideCapabilities();
66+
$this->initialStateService->providePublicShare($updatable);
6467

6568
Util::addScript('richdocuments', 'richdocuments-viewer', 'viewer');
6669
Util::addScript('richdocuments', 'richdocuments-public', 'viewer');

lib/Service/InitialStateService.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,11 @@ public function provideDocument(Wopi $wopi, array $params): void {
7575
$this->provideOptions();
7676
}
7777

78+
public function providePublicShare(?bool $userInEditGroups = true): void {
79+
$this->initialState->provideInitialState('userInEditGroups', $userInEditGroups);
80+
$this->provideCapabilities();
81+
}
82+
7883
public function prepareParams(array $params): array {
7984
$defaults = [
8085
'instanceId' => $this->config->getSystemValue('instanceid'),

src/public.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
isDownloadHidden,
77
} from './helpers/index.js'
88
import NewFileMenu from './view/NewFileMenu.js'
9+
import { loadState } from '@nextcloud/initial-state'
910

1011
const optionalMimetypes = getCapabilities().richdocuments.mimetypesNoDefaultOpen
1112

0 commit comments

Comments
 (0)