Skip to content

Commit 34c9e8d

Browse files
authored
Merge pull request #4730 from codewithvk/private/codewithvk/iframe_ui
fix(setting-iframe): move iframe to bottom and set height to 2000px
2 parents 6a4eb9b + 712cf1b commit 34c9e8d

3 files changed

Lines changed: 16 additions & 17 deletions

File tree

src/components/AdminSettings.vue

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -217,14 +217,6 @@
217217
</div>
218218
</NcModal>
219219

220-
<CoolFrame v-if="tokenGenerated"
221-
class="section"
222-
:iframe-type="'admin'"
223-
:iframe-url="settings.setting_iframe_url"
224-
:access-token="accessToken"
225-
:access-token-t-t-l="accessTokenTTL"
226-
:wopi-setting-base-url="wopiSettingBaseUrl" />
227-
228220
<div v-if="isSetup" id="advanced-settings" class="section">
229221
<h2>{{ t('richdocuments', 'Advanced settings') }}</h2>
230222
<SettingsCheckbox :value="isOoxml"
@@ -414,6 +406,14 @@
414406
</div>
415407

416408
<GlobalTemplates v-if="isSetup" />
409+
410+
<CoolFrame v-if="tokenGenerated"
411+
class="section"
412+
:iframe-type="'admin'"
413+
:iframe-url="settings.setting_iframe_url"
414+
:access-token="accessToken"
415+
:access-token-t-t-l="accessTokenTTL"
416+
:wopi-setting-base-url="wopiSettingBaseUrl" />
417417
</div>
418418
</template>
419419

src/components/CoolFrame.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export default {
8686
.cool-frame-iframe {
8787
width: 100%;
8888
border: none;
89-
height: 60vh;
89+
height: 2000px;
9090
overflow-y: auto;
9191
}
9292
</style>

src/components/PersonalSettings.vue

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,6 @@
3434
</em>
3535
</p>
3636

37-
<!-- user settings iframe -->
38-
<CoolFrame v-if="tokenGenerated"
39-
:iframe-type="'user'"
40-
:iframe-url="settingIframeUrl"
41-
:access-token="accessToken"
42-
:access-token-t-t-l="accessTokenTTL"
43-
:wopi-setting-base-url="wopiSettingBaseUrl" />
44-
4537
<!-- Zotero -->
4638
<div class="zotero-section">
4739
<p><strong>{{ t('richdocuments', 'Zotero') }}</strong></p>
@@ -118,6 +110,13 @@
118110
</em>
119111
</p>
120112
</div>
113+
<!-- user settings iframe -->
114+
<CoolFrame v-if="tokenGenerated"
115+
:iframe-type="'user'"
116+
:iframe-url="settingIframeUrl"
117+
:access-token="accessToken"
118+
:access-token-t-t-l="accessTokenTTL"
119+
:wopi-setting-base-url="wopiSettingBaseUrl" />
121120
</NcSettingsSection>
122121
</template>
123122

0 commit comments

Comments
 (0)