Merge pull request #5394 from nextcloud/fix/db-doctrine-type

fix(migration): use doctrine string type

Author: juliusknorr

lib/Migration/Version10000Date20251217143558.php

@@ -10,6 +10,7 @@
 namespace OCA\Richdocuments\Migration;
 
 use Closure;
+use Doctrine\DBAL\Types\Type;
 use OCP\DB\ISchemaWrapper;
 use OCP\Migration\IOutput;
 use OCP\Migration\SimpleMigrationStep;
@@ -19,22 +20,6 @@
  * Update version column in richdocuments_wopi table to support alphanumeric versions
  */
 class Version10000Date20251217143558 extends SimpleMigrationStep {
-
-	/**
-	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
-	 * @param array $options
-	 */
-	#[Override]
-	public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
-	}
-
-	/**
-	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 */
 	#[Override]
 	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
 		/** @var ISchemaWrapper $schema */
@@ -45,33 +30,24 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
 		}
 
 		$table = $schema->getTable('richdocuments_wopi');
-		
+
 		if (!$table->hasColumn('version')) {
 			return null;
 		}
 
 		$column = $table->getColumn('version');
-		
+
 		if ($column->getType()->getName() === 'string') {
 			return null;
 		}
 
 		$table->changeColumn('version', [
-			'type' => 'string',
+			'type' => Type::getType('string'),
 			'notnull' => false,
 			'length' => 1024,
 			'default' => '0',
 		]);
 
 		return $schema;
 	}
-
-	/**
-	 * @param IOutput $output
-	 * @param Closure(): ISchemaWrapper $schemaClosure
-	 * @param array $options
-	 */
-	#[Override]
-	public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
-	}
 }

psalm.xml

@@ -41,6 +41,7 @@
 				<referencedClass name="OC\*" />
 				<referencedClass name="OC" />
 				<referencedClass name="OC\Security\CSP\ContentSecurityPolicyNonceManager" />
+				<referencedClass name="Doctrine\DBAL\Types\Type" />
 			</errorLevel>
 		</UndefinedClass>
 		<UndefinedDocblockClass>