Skip to content

Commit 6d71a90

Browse files
chripelzody
authored andcommitted
Update lib/Conversion/ConversionProvider.php
Confirmed: with the tryOpen=false change applied, the conversion is blocked with the translated "Conversion is blocked because the file is protected by Secure View." message in the log, instead of the ForbiddenException 500 that occurs with the default tryOpen=true (because fopen() on the SecureView wrapper throws). Accepting the suggestion. Thanks! Co-authored-by: Elizabeth Danzberger <elizabeth@elzody.dev> Signed-off-by: Christoph Schaefer <christoph.schaefer@nextcloud.com>
1 parent 0edc505 commit 6d71a90

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

lib/Conversion/ConversionProvider.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ public function convertFile(File $file, string $targetMimeType): mixed {
152152
$secured = $this->secureViewService->shouldSecure(
153153
$file->getInternalPath(),
154154
$file->getStorage(),
155+
false,
155156
);
156157
} catch (NotFoundException $e) {
157158
$this->logger->warning('Could not determine Secure View status for conversion target', ['exception' => $e]);

0 commit comments

Comments
 (0)