Skip to content

Commit be61dde

Browse files
committed
Digital Signature: Hide digital signature inputs from user settings
Since Collabora Online already supports digital signatures via the settings iframe, this patch is intended to only hide the UI inputs. The related variables will still be sent to Online through checkfileinfo, and migration cases will be handled as well. Online PR: CollaboraOnline/online#12913 Signed-off-by: codewithvk <vivek.javiya@collabora.com>
1 parent dc9ffcf commit be61dde

3 files changed

Lines changed: 0 additions & 174 deletions

File tree

css/admin.scss

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,18 +52,6 @@
5252
}
5353
}
5454

55-
textarea#documentSigningCertField {
56-
width: 600px;
57-
}
58-
59-
textarea#documentSigningKeyField {
60-
width: 600px;
61-
}
62-
63-
textarea#documentSigningCaField {
64-
width: 600px;
65-
}
66-
6755
input#zoteroAPIKeyField {
6856
width: 300px;
6957
}

src/components/DocSigningField.vue

Lines changed: 0 additions & 98 deletions
This file was deleted.

src/components/PersonalSettings.vue

Lines changed: 0 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -34,41 +34,6 @@
3434
</em>
3535
</p>
3636

37-
<!-- Document signing -->
38-
<div class="docsign-section">
39-
<p class="doc_sign_head">
40-
<strong>{{ t('richdocuments', 'Document signing') }}</strong>
41-
</p>
42-
<template v-if="hasDocumentSigningSupport">
43-
<div class="input-wrapper">
44-
<!-- Document Signing Cert -->
45-
<DocSigningField v-model="documentSigningCert"
46-
:label="t('richdocuments', 'Enter document signing cert (in PEM format)')"
47-
@save="val => setDocumentSigningCert(val)"
48-
@remove="() => setDocumentSigningCert('')" />
49-
<!-- Document Signing Key -->
50-
<DocSigningField v-model="documentSigningKey"
51-
:label="t('richdocuments', 'Enter document signing key')"
52-
@save="val => setDocumentSigningKey(val)"
53-
@remove="() => setDocumentSigningKey('')" />
54-
<!-- Document Signing CA -->
55-
<DocSigningField v-model="documentSigningCa"
56-
:label="t('richdocuments', 'Enter document signing CA chain')"
57-
@save="val => setDocumentSigningCa(val)"
58-
@remove="() => setDocumentSigningCa('')" />
59-
<p>
60-
<em>
61-
{{ t('richdocuments', 'To use document signing, specify your signing certificate, key and CA chain here.') }}
62-
</em>
63-
</p>
64-
</div>
65-
</template>
66-
<p v-else>
67-
<em>
68-
{{ t('richdocuments', 'This instance does not support document signing, because the feature is missing or disabled. Please contact the administrator.') }}
69-
</em>
70-
</p>
71-
</div>
7237
<!-- user settings iframe -->
7338
<CoolFrame v-if="tokenGenerated"
7439
:iframe-type="'user'"
@@ -85,7 +50,6 @@ import { showError, showSuccess } from '@nextcloud/dialogs'
8550
import NcSettingsSection from '@nextcloud/vue/dist/Components/NcSettingsSection.js'
8651
import NcTextField from '@nextcloud/vue/dist/Components/NcTextField.js'
8752
import NcButton from '@nextcloud/vue/dist/Components/NcButton.js'
88-
import DocSigningField from './DocSigningField.vue'
8953
import DeleteIcon from 'vue-material-design-icons/TrashCanOutline.vue'
9054
import FolderIcon from 'vue-material-design-icons/FolderOutline.vue'
9155
import axios from '@nextcloud/axios'
@@ -103,7 +67,6 @@ export default {
10367
NcSettingsSection,
10468
NcTextField,
10569
NcButton,
106-
DocSigningField,
10770
FolderIcon,
10871
DeleteIcon,
10972
CoolFrame,
@@ -120,10 +83,6 @@ export default {
12083
hasSettingIframeSupport: this.initial.hasSettingIframeSupport || false,
12184
settingIframeUrl: this.initial.setting_iframe_url || '',
12285
zoteroAPIKey: this.initial.zoteroAPIKey || '',
123-
hasDocumentSigningSupport: this.initial.hasDocumentSigningSupport || false,
124-
documentSigningCert: this.initial.documentSigningCert || '',
125-
documentSigningKey: this.initial.documentSigningKey || '',
126-
documentSigningCa: this.initial.documentSigningCa || '',
12786
tokenGenerated: false,
12887
accessToken: '',
12988
accessTokenTTL: '',
@@ -181,24 +140,6 @@ export default {
181140
this.templateFolder = ''
182141
}
183142
},
184-
async setDocumentSigningCert(val) {
185-
const success = await this.updateSetting({ documentSigningCertInput: val })
186-
if (success) {
187-
this.documentSigningCert = val
188-
}
189-
},
190-
async setDocumentSigningKey(val) {
191-
const success = await this.updateSetting({ documentSigningKeyInput: val })
192-
if (success) {
193-
this.documentSigningKey = val
194-
}
195-
},
196-
async setDocumentSigningCa(val) {
197-
const success = await this.updateSetting({ documentSigningCaInput: val })
198-
if (success) {
199-
this.documentSigningCa = val
200-
}
201-
},
202143
async updateSetting(settings) {
203144
try {
204145
const response = await axios.post(
@@ -242,11 +183,6 @@ export default {
242183
gap: 1rem;
243184
}
244185
245-
.doc_sign_head {
246-
padding-top: 10px;
247-
padding-bottom: 5px;
248-
}
249-
250186
.msg {
251187
display: inline-block;
252188
margin-bottom: 1rem;

0 commit comments

Comments
 (0)