fix: do not fetch remote collabora url for own server#4714
Merged
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
elzody
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Productivity team
juliusknorr
reviewed
Apr 29, 2025
juliusknorr
reviewed
Apr 29, 2025
elzody
force-pushed
the
fix/trusted-server
branch
from
90616ae to
5d83307
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
elzody
force-pushed
the
fix/trusted-server
branch
3 times, most recently
from
825e99d to
baed008
Compare
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
blizzz
approved these changes
May 6, 2025
Collaborator
Author
|
/backport to stable31 |
Collaborator
Author
|
/backport to stable30 |
Collaborator
Author
|
/backport to stable29 |
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
This was referenced May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When your own server is listed as a trusted server in the federated sharing options, there is no need to fetch the remote Collabora URL, as it would just be the one set internally.
TODO
Checklist