Skip to content

fix(setting-iframe): move iframe to bottom and set height to 2000px#4730

Merged
juliusknorr merged 1 commit into
nextcloud:mainfrom
codewithvk:private/codewithvk/iframe_ui
May 6, 2025
Merged

fix(setting-iframe): move iframe to bottom and set height to 2000px#4730
juliusknorr merged 1 commit into
nextcloud:mainfrom
codewithvk:private/codewithvk/iframe_ui

Conversation

@codewithvk
Copy link
Copy Markdown
Collaborator

@codewithvk codewithvk commented May 6, 2025

Follow up to #4787

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Comment thread src/components/CoolFrame.vue
@juliusknorr juliusknorr added bug Something isn't working design Related to the design labels May 6, 2025
@juliusknorr juliusknorr merged commit 34c9e8d into nextcloud:main May 6, 2025
52 checks passed
@pedropintosilva
Copy link
Copy Markdown
Contributor

@codewithvk can you do a follow up on this, to pass over the height of the contents ?

and then we can possibly backport this?

@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@juliusknorr
Copy link
Copy Markdown
Member

Follow up is there in #4787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working design Related to the design feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants