Skip to content

chore(test): add unit tests for RegisterTemplateFileCreatorListener#4773

Merged
juliusknorr merged 1 commit into
nextcloud:mainfrom
IONOS-Productivity:mk/test/template_creation_listener
May 20, 2025
Merged

chore(test): add unit tests for RegisterTemplateFileCreatorListener#4773
juliusknorr merged 1 commit into
nextcloud:mainfrom
IONOS-Productivity:mk/test/template_creation_listener

Conversation

@printminion-co
Copy link
Copy Markdown
Contributor

@printminion-co printminion-co commented May 16, 2025 •
edited
Loading

Summary

  • adds tests for RegisterTemplateFileCreatorListener

TODO

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@printminion-co printminion-co force-pushed the mk/test/template_creation_listener branch from 8f5b7ea to 76f14fb Compare May 16, 2025 13:54
@printminion-co printminion-co mentioned this pull request May 16, 2025
Merged
@printminion-co
chore(test): add unit tests for RegisterTemplateFileCreatorListener
7fabded 
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
@printminion-co printminion-co force-pushed the mk/test/template_creation_listener branch from 76f14fb to 7fabded Compare May 19, 2025 08:15
juliusknorr
juliusknorr approved these changes May 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this test 👍

@juliusknorr
Copy link
Copy Markdown
Member

juliusknorr commented May 20, 2025

Those CI failures seem new to me, but cannot be related to the added test

@juliusknorr juliusknorr merged commit c9bf193 into nextcloud:main May 20, 2025
58 of 68 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 31, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@printminion-co
Copy link
Copy Markdown
Contributor Author

printminion-co commented Jun 2, 2025

/backport to stable30

@backportbot backportbot Bot mentioned this pull request Jun 2, 2025
Merged
@printminion-co
Copy link
Copy Markdown
Contributor Author

printminion-co commented Jun 2, 2025

/backport to stable31

@backportbot backportbot Bot mentioned this pull request Jun 2, 2025
Merged
Copilot AI mentioned this pull request May 6, 2026
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@elzody elzody Awaiting requested review from elzody elzody is a code owner

Assignees

No one assigned

Labels

feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@printminion-co @juliusknorr