Skip to content

fix(CoolFrame): Init and accept postMessage for setting iframe height#4787

Merged
elzody merged 1 commit into
nextcloud:mainfrom
codewithvk:private/codewithvk/setup_and_fix_iframe_height
May 23, 2025
Merged

fix(CoolFrame): Init and accept postMessage for setting iframe height#4787
elzody merged 1 commit into
nextcloud:mainfrom
codewithvk:private/codewithvk/setup_and_fix_iframe_height

Conversation

@codewithvk
Copy link
Copy Markdown
Collaborator

@codewithvk codewithvk commented May 19, 2025

  • Resolves: #
  • Target version: main

Summary

Appropriate COOL PR: CollaboraOnline/online#11971

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@codewithvk codewithvk force-pushed the private/codewithvk/setup_and_fix_iframe_height branch from 9fba2a6 to acb25a2 Compare May 19, 2025 10:52
@juliusknorr juliusknorr force-pushed the private/codewithvk/setup_and_fix_iframe_height branch from acb25a2 to 6a67bb6 Compare May 21, 2025 05:26
juliusknorr
juliusknorr approved these changes May 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick inline, but otherwise this seems good

Comment thread src/components/CoolFrame.vue Outdated
@juliusknorr juliusknorr mentioned this pull request May 21, 2025
Merged
3 tasks
@codewithvk
fix(CoolFrame): Init and accept postMessage for setting iframe height
75270e0 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk codewithvk force-pushed the private/codewithvk/setup_and_fix_iframe_height branch from 6a67bb6 to 75270e0 Compare May 21, 2025 12:15
@elzody
Copy link
Copy Markdown
Collaborator

elzody commented May 23, 2025

/backport to stable31

@elzody elzody merged commit 2d7622a into nextcloud:main May 23, 2025
52 checks passed
@backportbot backportbot Bot mentioned this pull request May 23, 2025
Merged
2 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@elzody elzody elzody approved these changes

@pedropintosilva pedropintosilva Awaiting requested review from pedropintosilva

Assignees

No one assigned

Labels

feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codewithvk @elzody @juliusknorr