Skip to content

chore: remove dropped deprecated method call for share manager#4788

Merged
elzody merged 3 commits into
mainfrom
fix/share-manager
May 20, 2025
Merged

chore: remove dropped deprecated method call for share manager#4788
elzody merged 3 commits into
mainfrom
fix/share-manager

Conversation

@juliusknorr
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr commented May 20, 2025

Fix failing requests and CI jobs around direct editing due to removal of a deprecated method in server

{
  "reqId": "KKHotlHF7Kjx7WNHUwSD",
  "level": 3,
  "time": "2025-05-19T10:55:50+00:00",
  "remoteAddr": "10.1.0.254",
  "user": "--",
  "app": "index",
  "method": "GET",
  "url": "/index.php/apps/richdocuments/direct/EEc28MPVBCvm6ZVEffl1AuS2LAmufo3ytXg2MrjuBD69m7bH1hBMQXEUsJRiqXYv",
  "message": "Call to undefined method OC\\Server::getShareManager() in file '/home/runner/work/richdocuments/richdocuments/apps/richdocuments/lib/Controller/DirectViewController.php' line 136",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Cypress/13.17.0 Chrome/118.0.5993.159 Electron/27.3.10 Safari/537.36",
  "version": "32.0.0.0",
  "exception": {
    "Exception": "Exception",
    "Message": "Call to undefined method OC\\Server::getShareManager() in file '/home/runner/work/richdocuments/richdocuments/apps/richdocuments/lib/Controller/DirectViewController.php' line 136",
    "Code": 0,
    "Trace": [
      {
        "file": "/home/runner/work/richdocuments/richdocuments/lib/private/AppFramework/App.php",
        "line": 161,
        "function": "dispatch",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->"
      },
      {
        "file": "/home/runner/work/richdocuments/richdocuments/lib/private/Route/Router.php",
        "line": 313,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::"
      },
      {
        "file": "/home/runner/work/richdocuments/richdocuments/lib/base.php",
        "line": 1062,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "/home/runner/work/richdocuments/richdocuments/index.php",
        "line": 25,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "/home/runner/work/richdocuments/richdocuments/lib/private/AppFramework/Http/Dispatcher.php",
    "Line": 148,
    "Previous": {
      "Exception": "Error",
      "Message": "Call to undefined method OC\\Server::getShareManager()",
      "Code": 0,
      "Trace": [
        {
          "file": "/home/runner/work/richdocuments/richdocuments/apps/richdocuments/lib/Controller/DirectViewController.php",
          "line": 74,
          "function": "showPublicShare",
          "class": "OCA\\Richdocuments\\Controller\\DirectViewController",
          "type": "->"
        },
        {
          "file": "/home/runner/work/richdocuments/richdocuments/lib/private/AppFramework/Http/Dispatcher.php",
          "line": 202,
          "function": "show",
          "class": "OCA\\Richdocuments\\Controller\\DirectViewController",
          "type": "->"
        },
        {
          "file": "/home/runner/work/richdocuments/richdocuments/lib/private/AppFramework/Http/Dispatcher.php",
          "line": 116,
          "function": "executeController",
          "class": "OC\\AppFramework\\Http\\Dispatcher",
          "type": "->"
        },
        {
          "file": "/home/runner/work/richdocuments/richdocuments/lib/private/AppFramework/App.php",
          "line": 161,
          "function": "dispatch",
          "class": "OC\\AppFramework\\Http\\Dispatcher",
          "type": "->"
        },
        {
          "file": "/home/runner/work/richdocuments/richdocuments/lib/private/Route/Router.php",
          "line": 313,
          "function": "main",
          "class": "OC\\AppFramework\\App",
          "type": "::"
        },
        {
          "file": "/home/runner/work/richdocuments/richdocuments/lib/base.php",
          "line": 1062,
          "function": "match",
          "class": "OC\\Route\\Router",
          "type": "->"
        },
        {
          "file": "/home/runner/work/richdocuments/richdocuments/index.php",
          "line": 25,
          "function": "handleRequest",
          "class": "OC",
          "type": "::"
        }
      ],
      "File": "/home/runner/work/richdocuments/richdocuments/apps/richdocuments/lib/Controller/DirectViewController.php",
      "Line": 136
    },
    "message": "Call to undefined method OC\\Server::getShareManager() in file '/home/runner/work/richdocuments/richdocuments/apps/richdocuments/lib/Controller/DirectViewController.php' line 136",
    "exception": {},
    "CustomMessage": "Call to undefined method OC\\Server::getShareManager() in file '/home/runner/work/richdocuments/richdocuments/apps/richdocuments/lib/Controller/DirectViewController.php' line 136"
  }
}

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr requested a review from elzody as a code owner May 20, 2025 14:06
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels May 20, 2025
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@elzody elzody merged commit bafa44c into main May 20, 2025
68 checks passed
@elzody elzody deleted the fix/share-manager branch May 20, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants