Skip to content

enh: set ooxml as default doc_format#4858

Merged
elzody merged 1 commit into
mainfrom
feat/default-ooxml-format
Jul 11, 2025
Merged

enh: set ooxml as default doc_format#4858
elzody merged 1 commit into
mainfrom
feat/default-ooxml-format

Conversation

@grnd-alt

Copy link
Copy Markdown
Member

@grnd-alt grnd-alt force-pushed the feat/default-ooxml-format branch from e8eeea1 to 0535cc3 Compare June 16, 2025 11:34

@juliusknorr juliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a few more occurences of the doc_format config key that I think also need an adjustment:

lib/Settings/Admin.php
48:					'doc_format' => $this->config->getAppValue('richdocuments', 'doc_format'),

lib/TemplateManager.php
416:		$ooxml = $this->config->getAppValue(Application::APPNAME, 'doc_format', '') === 'ooxml';
445:		$ooxml = $this->config->getAppValue(Application::APPNAME, 'doc_format', '') === 'ooxml';

lib/Service/SlideDeckService.php
44:		$ooxml = $this->config->getAppValue(Application::APPNAME, 'doc_format', '') === 'ooxml';

@juliusknorr

juliusknorr commented Jun 17, 2025

Copy link
Copy Markdown
Member

Also please add relevant labels

@juliusknorr juliusknorr added enhancement New feature or request 2. developing Work in progress labels Jun 17, 2025
@grnd-alt grnd-alt force-pushed the feat/default-ooxml-format branch from 0535cc3 to a438614 Compare June 19, 2025 09:23
@grnd-alt grnd-alt requested a review from juliusknorr June 19, 2025 09:24
@elzody elzody added 3. to review Ready to be reviewed and removed 2. developing Work in progress labels Jul 11, 2025
Signed-off-by: grnd-alt <github@belakkaf.net>
@elzody elzody force-pushed the feat/default-ooxml-format branch from a438614 to 8b464b6 Compare July 11, 2025 19:02
@elzody elzody merged commit 2844800 into main Jul 11, 2025
69 of 72 checks passed
@elzody elzody deleted the feat/default-ooxml-format branch July 11, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to OOXML for improved interoperability

3 participants