enh: set ooxml as default doc_format#4858
Merged
Merged
Conversation
grnd-alt
commented
Jun 16, 2025
Member
- Resolves: Switch to OOXML for improved interoperability #4812
e8eeea1 to
0535cc3
Compare
juliusknorr
requested changes
Jun 17, 2025
juliusknorr
left a comment
Member
There was a problem hiding this comment.
There seem to be a few more occurences of the doc_format config key that I think also need an adjustment:
lib/Settings/Admin.php
48: 'doc_format' => $this->config->getAppValue('richdocuments', 'doc_format'),
lib/TemplateManager.php
416: $ooxml = $this->config->getAppValue(Application::APPNAME, 'doc_format', '') === 'ooxml';
445: $ooxml = $this->config->getAppValue(Application::APPNAME, 'doc_format', '') === 'ooxml';
lib/Service/SlideDeckService.php
44: $ooxml = $this->config->getAppValue(Application::APPNAME, 'doc_format', '') === 'ooxml';
Member
|
Also please add relevant labels |
0535cc3 to
a438614
Compare
elzody
approved these changes
Jul 11, 2025
Signed-off-by: grnd-alt <github@belakkaf.net>
a438614 to
8b464b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.