Skip to content

Digital Signature: Hide digital signature inputs from user settings#5233

Open
codewithvk wants to merge 1 commit into
mainfrom
private/codewithvk/hide_digital_signature
Open

Digital Signature: Hide digital signature inputs from user settings#5233
codewithvk wants to merge 1 commit into
mainfrom
private/codewithvk/hide_digital_signature

Conversation

@codewithvk

@codewithvk codewithvk commented Dec 15, 2025

Copy link
Copy Markdown
Collaborator
  • Resolves:
  • Target version: main

Summary

Digital Signature: Hide digital signature inputs from user settings

Since Collabora Online already supports digital signatures via the settings iframe, this patch is intended to only hide the UI inputs. The related variables will still be sent to Online through checkfileinfo, and migration cases will be handled as well.

Online PR: CollaboraOnline/online#12913

@juliusknorr

Copy link
Copy Markdown
Member

Since which version does Collabora show this in the settings iframe? Should we only hide it in case we know this is present?

@juliusknorr juliusknorr added enhancement New feature or request 3. to review Ready to be reviewed labels Dec 16, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@jazevedo-coll

Copy link
Copy Markdown

Since which version does Collabora show this in the settings iframe? Should we only hide it in case we know this is present?

Hi @juliusknorr this is already available for CODE since 25.04.8-1
As for COOL it will be included in 25.04.8-3 which is to be released this month.

@juliusknorr

Copy link
Copy Markdown
Member

Can you elaborate a bit further how the migration works? Can we force a migration on the Nextcloud side somehow? I fear that otherwise we may always have to keep the old logic on the backend side.

@codewithvk

codewithvk commented Mar 9, 2026

Copy link
Copy Markdown
Collaborator Author

Can you elaborate a bit further how the migration works? Can we force a migration on the Nextcloud side somehow? I fear that otherwise we may always have to keep the old logic on the backend side.

So currently on the online side, if Nextcloud WOPI CheckFileInfo has any values, they will override the new JSON file (created on the COOL side), and that will always be referenced for the new values.
Ref: https://github.com/CollaboraOnline/online/pull/12913/changes#diff-1346662577e72b9ac23f0977699d096e506badf1ce7d2cf56a84ab8769d9be66R1728-R1760

In terms of backend logic, I don't have many plans right now, as we might need to fully migrate it in future versions. For this PR, I'm just removing the logic from the client side.

For now let's remove from UI so user can't see two inputs for same fileds.

@juliusknorr juliusknorr force-pushed the private/codewithvk/hide_digital_signature branch from be61dde to b76e87a Compare March 11, 2026 21:39
Since Collabora Online already supports digital signatures via the settings iframe, this patch is intended to only hide the UI inputs. The related variables will still be sent to Online through checkfileinfo, and migration cases will be handled as well.

Online PR:  CollaboraOnline/online#12913

Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@elzody elzody force-pushed the private/codewithvk/hide_digital_signature branch from b76e87a to 3b3e89a Compare June 3, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed enhancement New feature or request feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants