Digital Signature: Hide digital signature inputs from user settings#5233
Digital Signature: Hide digital signature inputs from user settings#5233codewithvk wants to merge 1 commit into
Conversation
|
Since which version does Collabora show this in the settings iframe? Should we only hide it in case we know this is present? |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Hi @juliusknorr this is already available for CODE since 25.04.8-1 |
|
Can you elaborate a bit further how the migration works? Can we force a migration on the Nextcloud side somehow? I fear that otherwise we may always have to keep the old logic on the backend side. |
So currently on the online side, if Nextcloud WOPI CheckFileInfo has any values, they will override the new JSON file (created on the COOL side), and that will always be referenced for the new values. In terms of backend logic, I don't have many plans right now, as we might need to fully migrate it in future versions. For this PR, I'm just removing the logic from the client side. For now let's remove from UI so user can't see two inputs for same fileds. |
be61dde to
b76e87a
Compare
Since Collabora Online already supports digital signatures via the settings iframe, this patch is intended to only hide the UI inputs. The related variables will still be sent to Online through checkfileinfo, and migration cases will be handled as well. Online PR: CollaboraOnline/online#12913 Signed-off-by: codewithvk <vivek.javiya@collabora.com>
b76e87a to
3b3e89a
Compare
Summary
Digital Signature: Hide digital signature inputs from user settings
Since Collabora Online already supports digital signatures via the settings iframe, this patch is intended to only hide the UI inputs. The related variables will still be sent to Online through checkfileinfo, and migration cases will be handled as well.
Online PR: CollaboraOnline/online#12913