Office Overview Part 4/5 - All / Mine / Shared filter chips#5679
Merged
Conversation
Add owner-based filtering to the files section: - 'Mine' (default): files owned by the current user that are not on a shared or group mount (mirrors apps/files PersonalFiles filter) - 'Shared with me': files where nc:mount-type === 'shared' - 'All': no filter applied Both properties (oc:owner-id → node.owner, nc:mount-type) are already returned by getDavProperties() so no extra API call is needed. Three NcButton chips (size=small, aria-pressed) in a role=group below the section title give keyboard-accessible toggle behaviour. The empty state is moved inside the section so the chips remain visible when a filter yields no results, allowing the user to switch back. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
…rride Override --button-radius on the filter NcButton elements so they render as pill-shaped chips rather than square-cornered small buttons. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
moodyjmz
changed the title
Base automatically changed from
feat/overview-pr4-list-view
to
feat/office-overview-v2
May 20, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of 5 — see #5678 for the full series. Merge all PRs into
feat/office-overview-v2in order.primaryvariant--button-radiusoverride