fix(database): add index for wopi expiry column#5745
Merged
Conversation
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Collaborator
Author
|
/backport to stable34 please |
Collaborator
Author
|
/backport to stable33 please |
Collaborator
Author
|
/backport to stable32 please |
Collaborator
Author
|
/backport to stable31 please |
juliusknorr
approved these changes
Jun 9, 2026
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expirycolumn ofoc_richdocuments_wopi#5711Summary
Because the cleanup background job now deletes all expired WOPI tokens in a single query instead of batching them, it makes sense to introduce an index on the
expirycolumn of theoc_richdocuments_wopitable. This PR introduces a change to the existing database migration that creates the table (adding an index at creation time) as well as a newAddMissingIndicesevent listener that creates the index when runningocc db:add-missing-indices.I tested everything manually and it works flawlessy. I was not sure how to implement automated testing for this.
Checklist