fix: guard share attribute parse#5806
Open
rikled wants to merge 1 commit into
Open
Conversation
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com> Assisted-by: Claude Code:Opus 4.8
elzody
force-pushed
the
fix/shareattrparse
branch
from
9ece393 to
4205489
Compare
Collaborator
|
/backport to stable34 please |
Collaborator
|
/backport to stable33 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Claude Code:Opus 4.8
Summary
The file picker's filter calls JSON.parse(node.attributes['share-attributes']) unconditionally, but the picker's default PROPFIND never requests share-attributes, so it's always undefined. JSON.parse(undefined) throws "unexpected character at line 1 column 1", breaking image insertion for every node. This guards the parse, defaulting to allowing download when the attribute is absent.
Checklist