Merge pull request #59867 from nextcloud/fix/public-share-download-redirect-trailing-question-mark

susnux · web-flow · commit 07616938a8c3 · 2026-04-23T16:21:56.000+02:00
fix(files_sharing): Drop trailing '?' from public download redirect URL
diff --git a/apps/files_sharing/lib/Controller/ShareController.php b/apps/files_sharing/lib/Controller/ShareController.php
@@ -401,7 +401,9 @@ public function downloadShare(string $token, ?string $files = null, string $path
 		}
 
 		$davUrl = '/public.php/dav/files/' . $token . $davPath;
-		$davUrl .= '?' . http_build_query($params);
+		if (!empty($params)) {
+			$davUrl .= '?' . http_build_query($params);
+		}
 		return new RedirectResponse($this->urlGenerator->getAbsoluteURL($davUrl));
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -401,7 +401,9 @@ public function downloadShare(string $token, ?string $files = null, string $path`
`401`	`401`	`}`
`402`	`402`
`403`	`403`	`$davUrl = '/public.php/dav/files/' . $token . $davPath;`
`404`		`- $davUrl .= '?' . http_build_query($params);`
	`404`	`+ if (!empty($params)) {`
	`405`	`+ $davUrl .= '?' . http_build_query($params);`
	`406`	`+ }`
`405`	`407`	`return new RedirectResponse($this->urlGenerator->getAbsoluteURL($davUrl));`
`406`	`408`	`}`
`407`	`409`	`}`