fix(accounts): fix CI failures in admin scope ceiling feature

- Rename SCOPE_ORDER -> PROPERTY_SCOPE_ORDER to avoid matching the
  IAccountManager::SCOPE_* psalm wildcard used in IAccountProperty
  docblocks, which caused MismatchingDocblockParamType errors
- Add missing parens around arrow function arg in FederationControl.vue
  to satisfy @stylistic/arrow-parens eslint rule
- Inline arrow function body in PersonalInfo.php to satisfy rector
  formatting rules

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: miaulalala

apps/settings/lib/Settings/Personal/PersonalInfo.php

@@ -117,9 +117,7 @@ public function getForm(): TemplateResponse {
 
 		$maxPropertyScopes = array_filter(
 			$this->config->getSystemValue('account_manager.max_property_scope', []),
-			static fn (string $scope, string $property): bool =>
-				in_array($property, IAccountManager::ALLOWED_PROPERTIES, true)
-				&& in_array($scope, IAccountManager::ALLOWED_SCOPES, true),
+			static fn (string $scope, string $property): bool => in_array($property, IAccountManager::ALLOWED_PROPERTIES, true) && in_array($scope, IAccountManager::ALLOWED_SCOPES, true),
 			ARRAY_FILTER_USE_BOTH,
 		);
 

apps/settings/src/components/PersonalInfo/shared/FederationControl.vue

@@ -141,7 +141,7 @@ export default {
 			if (maxScope) {
 				const order = [SCOPE_ENUM.PRIVATE, SCOPE_ENUM.LOCAL, SCOPE_ENUM.FEDERATED, SCOPE_ENUM.PUBLISHED]
 				const maxIndex = order.indexOf(maxScope)
-				return scopes.filter(scope => order.indexOf(scope) <= maxIndex)
+				return scopes.filter((scope) => order.indexOf(scope) <= maxIndex)
 			}
 
 			return scopes

lib/private/Accounts/AccountManager.php

@@ -124,8 +124,8 @@ protected function testPropertyScope(IAccountProperty $property, array $allowedS
 		$maxScopes = $this->config->getSystemValue('account_manager.max_property_scope', []);
 		if (isset($maxScopes[$property->getName()])) {
 			$maxScope = $maxScopes[$property->getName()];
-			$currentOrder = self::SCOPE_ORDER[$property->getScope()] ?? 0;
-			$maxOrder = self::SCOPE_ORDER[$maxScope] ?? PHP_INT_MAX;
+			$currentOrder = self::PROPERTY_SCOPE_ORDER[$property->getScope()] ?? 0;
+			$maxOrder = self::PROPERTY_SCOPE_ORDER[$maxScope] ?? PHP_INT_MAX;
 			if ($currentOrder > $maxOrder) {
 				if ($throwOnData) {
 					throw new InvalidArgumentException('scope');

lib/public/Accounts/IAccountManager.php

@@ -61,12 +61,8 @@ interface IAccountManager {
 
 	/**
 	 * Visibility order of scopes from least to most visible.
-	 * Used to compare scope levels when enforcing admin-configured ceilings.
-	 *
-	 * Admins may configure a per-property scope ceiling via the system config
-	 * key `account_manager.max_property_scope` (array of property => scope).
-	 * A user may not set a property to a scope with a higher index than the
-	 * configured ceiling.
+	 * Used to compare scope levels when enforcing admin-configured ceilings
+	 * via the ``account_manager.max_property_scope`` system config key.
 	 *
 	 * Warning: restricting properties that federation depends on
 	 * (``PROPERTY_DISPLAYNAME``, ``PROPERTY_EMAIL``, ``PROPERTY_AVATAR``,
@@ -75,7 +71,7 @@ interface IAccountManager {
 	 *
 	 * @since 32.0.0
 	 */
-	public const SCOPE_ORDER = [
+	public const PROPERTY_SCOPE_ORDER = [
 		self::SCOPE_PRIVATE => 0,
 		self::SCOPE_LOCAL => 1,
 		self::SCOPE_FEDERATED => 2,