perf: Replace more calls from getUserGroups to getUserGroupIds

Faster as we only need the gid and not the full group objects

Signed-off-by: Carl Schwan <carlschwan@kde.org>

Author: CarlSchwan

apps/provisioning_api/lib/Controller/AUserDataOCSController.php

@@ -106,11 +106,7 @@ protected function getUserData(string $userId, bool $includeScopes = false): ?ar
 
 		// Get groups data
 		$userAccount = $this->accountManager->getAccount($targetUserObject);
-		$groups = $this->groupManager->getUserGroups($targetUserObject);
-		$gids = [];
-		foreach ($groups as $group) {
-			$gids[] = $group->getGID();
-		}
+		$gids = $this->groupManager->getUserGroupIds($targetUserObject);
 
 		if ($isAdmin || $isDelegatedAdmin) {
 			try {

apps/provisioning_api/lib/Controller/UsersController.php

@@ -1080,8 +1080,7 @@ public function editUserMultiField(
 		}
 
 		if ($groups !== null) {
-			$currentGroups = $this->groupManager->getUserGroups($targetUser);
-			$currentGroupIds = array_map(fn (IGroup $g) => $g->getGID(), $currentGroups);
+			$currentGroupIds = $this->groupManager->getUserGroupIds($targetUser);
 			foreach (array_diff($currentGroupIds, $groups) as $gid) {
 				$this->groupManager->get($gid)?->removeUser($targetUser);
 			}

apps/provisioning_api/tests/Controller/GroupsControllerTest.php

@@ -483,8 +483,8 @@ public function testGetGroupUsersDetails(): void {
 			->with($gid)
 			->willReturn($group);
 		$this->groupManager->expects($this->any())
-			->method('getUserGroups')
-			->willReturn([$group]);
+			->method('getUserGroupIds')
+			->willReturn(['ncg1']);
 
 		/** @var MockObject */
 		$this->subAdminManager->expects($this->any())
@@ -538,8 +538,8 @@ public function testGetGroupUsersDetailsEncoded(): void {
 			->with($gid)
 			->willReturn($group);
 		$this->groupManager->expects($this->any())
-			->method('getUserGroups')
-			->willReturn([$group]);
+			->method('getUserGroupIds')
+			->willReturn(['Department A/B C/D']);
 
 		/** @var MockObject */
 		$this->subAdminManager->expects($this->any())

apps/provisioning_api/tests/Controller/UsersControllerTest.php

@@ -1196,8 +1196,8 @@ public function testGetUserDataAsAdmin(): void {
 			->willReturn(true);
 		$this->groupManager
 			->expects($this->any())
-			->method('getUserGroups')
-			->willReturn([$group0, $group1, $group2]);
+			->method('getUserGroupIds')
+			->willReturn(['group0', 'group1', 'group2']);
 		$this->groupManager
 			->expects($this->once())
 			->method('getSubAdmin')
@@ -1206,15 +1206,6 @@ public function testGetUserDataAsAdmin(): void {
 			->expects($this->once())
 			->method('getSubAdminsGroups')
 			->willReturn([$group3]);
-		$group0->expects($this->exactly(1))
-			->method('getGID')
-			->willReturn('group0');
-		$group1->expects($this->exactly(1))
-			->method('getGID')
-			->willReturn('group1');
-		$group2->expects($this->exactly(1))
-			->method('getGID')
-			->willReturn('group2');
 		$group3->expects($this->once())
 			->method('getGID')
 			->willReturn('group3');
@@ -2759,7 +2750,7 @@ public function testUpdateUserGroupDiff(): void {
 		$newGroup = $this->createMock(IGroup::class);
 		$newGroup->method('getGID')->willReturn('newgroup');
 
-		$this->groupManager->method('getUserGroups')->willReturn([$oldGroup]);
+		$this->groupManager->method('getUserGroupIds')->willReturn(['oldgroup']);
 		$this->groupManager->method('groupExists')->willReturn(true);
 		$this->groupManager->method('get')->willReturnMap([
 			['newgroup', $newGroup],