feature(files): Add file type TYPE_SYMLINK to FileInfo

Author: taminob

apps/dav/lib/Connector/Sabre/Directory.php

@@ -229,7 +229,7 @@ public function createSymlink($name, $target) {
 			$storage->getUpdater()->update($internalPath);
 			$newEtag = $storage->getETag($internalPath);
 			$infoData = [
-				'type' => FileInfo::TYPE_FILE,
+				'type' => FileInfo::TYPE_SYMLINK,
 				'etag' => $newEtag,
 			];
 			$path = \OC\Files\Filesystem::normalizePath($this->path . '/' . $name);

apps/files_reminders/lib/Notification/Notifier.php

@@ -104,6 +104,7 @@ public function prepare(INotification $notification, string $languageCode): INot
 				$label = match ($node->getType()) {
 					FileInfo::TYPE_FILE => $l->t('View file'),
 					FileInfo::TYPE_FOLDER => $l->t('View folder'),
+					FileInfo::TYPE_SYMLINK => $l->t('View symlink'),
 				};
 
 				$this->addActionButton($notification, $label);

lib/private/Encryption/Util.php

@@ -154,6 +154,7 @@ public function createHeader(array $headerData, IEncryptionModule $encryptionMod
 
 	/**
 	 * go recursively through a dir and collect all files and sub files.
+	 * the resulting list will not contain symlinks
 	 *
 	 * @param string $dir relative to the users files folder
 	 * @return array with list of files relative to the users files folder
@@ -167,9 +168,9 @@ public function getAllFiles($dir) {
 			$content = $this->rootView->getDirectoryContent($dir);
 
 			foreach ($content as $c) {
-				if ($c->getType() === 'dir') {
+				if ($c->getType() === \OCP\Files\FileInfo::TYPE_FOLDER) {
 					$dirList[] = $c->getPath();
-				} else {
+				} elseif($c->getType() === \OCP\Files\FileInfo::TYPE_FILE) {
 					$result[] = $c->getPath();
 				}
 			}

lib/private/Files/FileInfo.php

@@ -248,7 +248,9 @@ public function getPermissions() {
 	}
 
 	/**
-	 * @return string \OCP\Files\FileInfo::TYPE_FILE|\OCP\Files\FileInfo::TYPE_FOLDER
+	 * @return string \OCP\Files\FileInfo::TYPE_FILE|
+	 *                \OCP\Files\FileInfo::TYPE_FOLDER
+	 *                \OCP\Files\FileInfo::TYPE_SYMLINK
 	 */
 	public function getType() {
 		if (!isset($this->data['type'])) {

lib/private/Files/Node/HookConnector.php

@@ -229,7 +229,7 @@ private function getNodeForPath(string $path): Node {
 				return new NonExistingFile($this->root, $this->view, $fullPath, $info);
 			}
 		}
-		if ($info->getType() === FileInfo::TYPE_FILE) {
+		if ($info->getType() === FileInfo::TYPE_FILE || $info->getType() === FileInfo::TYPE_SYMLINK) {
 			return new File($this->root, $this->view, $info->getPath(), $info);
 		} else {
 			return new Folder($this->root, $this->view, $info->getPath(), $info);

lib/public/Files/DavUtil.php

@@ -94,7 +94,7 @@ public static function getDavPermissions(FileInfo $info): string {
 			if ($isWritable) {
 				$p .= 'W';
 			}
-		} else {
+		} elseif ($info->getType() === FileInfo::TYPE_FOLDER) {
 			if ($permissions & Constants::PERMISSION_CREATE) {
 				$p .= 'CK';
 			}

lib/public/Files/FileInfo.php

@@ -45,6 +45,10 @@ interface FileInfo {
 	 * @since 7.0.0
 	 */
 	public const TYPE_FOLDER = 'dir';
+	/**
+	 * @since TODO
+	 */
+	public const TYPE_SYMLINK = 'symlink';
 
 	/**
 	 * @const \OCP\Files\FileInfo::SPACE_NOT_COMPUTED Return value for a not computed space value
@@ -179,7 +183,9 @@ public function getPermissions();
 	/**
 	 * Check whether this is a file or a folder
 	 *
-	 * @return string \OCP\Files\FileInfo::TYPE_FILE|\OCP\Files\FileInfo::TYPE_FOLDER
+	 * @return string \OCP\Files\FileInfo::TYPE_FILE|
+	 *                \OCP\Files\FileInfo::TYPE_FOLDER|
+	 *                \OCP\Files\FileInfo::TYPE_SYMLINK
 	 * @since 7.0.0
 	 */
 	public function getType();