Merge pull request #55405 from nextcloud/carl/cleanup-some-tests

refactor: Cleanup some unit tests

Author: nickvergessen

tests/lib/Accounts/AccountManagerTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2016 ownCloud, Inc.

tests/lib/Accounts/AccountPropertyCollectionTest.php

@@ -17,8 +17,7 @@
 use Test\TestCase;
 
 class AccountPropertyCollectionTest extends TestCase {
-	/** @var IAccountPropertyCollection */
-	protected $collection;
+	protected IAccountPropertyCollection $collection;
 
 	protected const COLLECTION_NAME = 'my_multivalue_property';
 
@@ -28,10 +27,7 @@ public function setUp(): void {
 		$this->collection = new AccountPropertyCollection(self::COLLECTION_NAME);
 	}
 
-	/**
-	 * @return IAccountProperty|MockObject
-	 */
-	protected function makePropertyMock(string $propertyName): MockObject {
+	protected function makePropertyMock(string $propertyName): IAccountProperty&MockObject {
 		$mock = $this->createMock(IAccountProperty::class);
 		$mock->expects($this->any())
 			->method('getName')

tests/lib/Accounts/AccountPropertyTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later

tests/lib/Accounts/AccountTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later

tests/lib/Accounts/HooksTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
@@ -24,14 +26,10 @@
  * @group DB
  */
 class HooksTest extends TestCase {
-	/** @var LoggerInterface|MockObject */
-	private $logger;
-
-	/** @var AccountManager|MockObject */
-	private $accountManager;
 
-	/** @var Hooks */
-	private $hooks;
+	private LoggerInterface&MockObject $logger;
+	private AccountManager&MockObject $accountManager;
+	private Hooks $hooks;
 
 	protected function setUp(): void {
 		parent::setUp();

tests/lib/Activity/ManagerTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
@@ -8,6 +10,7 @@
 
 namespace Test\Activity;
 
+use OC\Activity\Manager;
 use OCP\Activity\Exceptions\IncompleteActivityException;
 use OCP\Activity\IConsumer;
 use OCP\Activity\IEvent;
@@ -23,8 +26,7 @@
 use Test\TestCase;
 
 class ManagerTest extends TestCase {
-	/** @var \OC\Activity\Manager */
-	private $activityManager;
+	private Manager $activityManager;
 
 	protected IRequest&MockObject $request;
 	protected IUserSession&MockObject $session;
@@ -43,7 +45,7 @@ protected function setUp(): void {
 		$this->richTextFormatter = $this->createMock(IRichTextFormatter::class);
 		$this->time = $this->createMock(ITimeFactory::class);
 
-		$this->activityManager = new \OC\Activity\Manager(
+		$this->activityManager = new Manager(
 			$this->request,
 			$this->session,
 			$this->config,

tests/lib/App/AppStore/Bundles/BundleBase.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
@@ -9,19 +11,15 @@
 
 use OC\App\AppStore\Bundles\Bundle;
 use OCP\IL10N;
+use PHPUnit\Framework\MockObject\MockObject;
 use Test\TestCase;
 
 abstract class BundleBase extends TestCase {
-	/** @var IL10N|\PHPUnit\Framework\MockObject\MockObject */
-	protected $l10n;
-	/** @var Bundle */
-	protected $bundle;
-	/** @var string */
-	protected $bundleIdentifier;
-	/** @var string */
-	protected $bundleName;
-	/** @var array */
-	protected $bundleAppIds;
+	protected IL10N&MockObject $l10n;
+	protected Bundle $bundle;
+	protected string $bundleIdentifier;
+	protected string $bundleName;
+	protected array $bundleAppIds;
 
 	protected function setUp(): void {
 		parent::setUp();

tests/lib/App/AppStore/Bundles/BundleFetcherTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
@@ -15,13 +17,12 @@
 use OC\App\AppStore\Bundles\PublicSectorBundle;
 use OC\App\AppStore\Bundles\SocialSharingBundle;
 use OCP\IL10N;
+use PHPUnit\Framework\MockObject\MockObject;
 use Test\TestCase;
 
 class BundleFetcherTest extends TestCase {
-	/** @var IL10N|\PHPUnit\Framework\MockObject\MockObject */
-	private $l10n;
-	/** @var BundleFetcher */
-	private $bundleFetcher;
+	private IL10N&MockObject $l10n;
+	private BundleFetcher $bundleFetcher;
 
 	protected function setUp(): void {
 		parent::setUp();

tests/lib/App/AppStore/Bundles/EducationBundleTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later

tests/lib/App/AppStore/Bundles/EnterpriseBundleTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later