fixup! fixup! test(installer): migrate end-to-end tests to PlayWright

Author: susnux

.github/workflows/playwright.yml

@@ -164,20 +164,20 @@ jobs:
           - '3306/tcp'
         env:
           MYSQL_ROOT_PASSWORD: rootpassword
-          MYSQL_USER: oc_autotest
+          MYSQL_USER: nextcloud
           MYSQL_PASSWORD: nextcloud
-          MYSQL_DATABASE: oc_autotest
+          MYSQL_DATABASE: nextcloud
         options: --health-cmd="mysqladmin ping" --health-interval 5s --health-timeout 2s --health-retries 10
 
       mariadb:
         image: mariadb:12.3 # zizmor: ignore[unpinned-images]
         ports:
           - '3306/tcp'
         env:
-          MYSQL_ROOT_PASSWORD: rootpassword
-          MYSQL_USER: oc_autotest
-          MYSQL_PASSWORD: nextcloud
-          MYSQL_DATABASE: oc_autotest
+          MARIADB_ROOT_PASSWORD: rootpassword
+          MARIADB_USER: nextcloud
+          MARIADB_PASSWORD: nextcloud
+          MARIADB_DATABASE: nextcloud
         options: --health-cmd="mariadb-admin ping" --health-interval 5s --health-timeout 2s --health-retries 5
 
       postgres:
@@ -238,8 +238,6 @@ jobs:
 
     - name: Run Playwright setup tests
       run: npm run playwright:setup
-      env:
-        PLAYWRIGHT_SETUP: 'true'
 
     - name: Show logs
       if: failure()

tests/playwright/e2e/core/setup.spec.ts

@@ -13,9 +13,9 @@ import { SetupPage } from '../../support/sections/SetupPage.ts'
 /**
  * Installation-wizard tests. They repeatedly UN-INSTALL the shared server (so it
  * can be set up again from scratch) and the non-SQLite cases need reachable
- * database containers, so they run only in the dedicated setup job — gated on
- * PLAYWRIGHT_SETUP and isolated in the `setup` Playwright project (see
- * playwright.config.ts). They are tagged `@setup` for selective runs.
+ * database containers, so they run only in the dedicated setup job —
+ * isolated in the `setup` Playwright project.
+ * They are tagged `@setup` for selective runs.
  */
 const test = base.extend<{ setupPage: SetupPage }>({
 	setupPage: async ({ page }, use) => {
@@ -42,8 +42,8 @@ const RECOMMENDED_APP_COUNT = APPSTORE_APPS.ocs.data.length
 const ENABLE_SUCCESS = { ocs: { meta: { status: 'ok', statuscode: 200, message: 'OK' }, data: { update_required: false } } }
 const ENABLE_FAILURE = { ocs: { meta: { status: 'failure', statuscode: 500, message: 'Forced failure' }, data: [] } }
 
-const MYSQL: DatabaseConnection = { user: 'oc_autotest', password: 'nextcloud', name: 'oc_autotest', host: 'mysql:3306' }
-const MARIADB: DatabaseConnection = { user: 'oc_autotest', password: 'nextcloud', name: 'oc_autotest', host: 'mariadb:3306' }
+const MYSQL: DatabaseConnection = { user: 'root', password: 'rootpassword', name: 'nextcloud', host: 'mysql:3306' }
+const MARIADB: DatabaseConnection = { user: 'root', password: 'rootpassword', name: 'nextcloud', host: 'mariadb:3306' }
 const POSTGRES: DatabaseConnection = { user: 'root', password: 'rootpassword', name: 'nextcloud', host: 'postgres:5432' }
 const ORACLE: DatabaseConnection = { user: 'system', password: 'oracle', name: 'FREE', host: 'oracle:1521' }
 

tests/playwright/start-nextcloud-server.js

@@ -47,18 +47,7 @@ async function start() {
 	// when present; a no-op locally and in the normal test job where it is absent.
 	await connectToActionsNetwork()
 
-	await runExec(['mkdir', '-p', 'apps-cypress'])
-	await runExec(['cp', 'cypress/fixtures/app.config.php', 'config'])
-
 	await waitOnNextcloud(ip)
-	// The installer (setup) tests immediately un-install and re-install the
-	// instance from scratch, so this initial app set is discarded — skip cloning
-	// the bundled apps (avoids a needless network dependency and is faster). The
-	// mounted `apps_writable` folder is normally created as a side effect of that
-	// clone, so create it explicitly or Nextcloud reports it missing.
-	if (process.env.PLAYWRIGHT_SETUP) {
-		await runExec(['mkdir', '-p', 'apps_writable'])
-	}
 	await configureNextcloud(process.env.PLAYWRIGHT_SETUP ? [] : ['viewer'])
 
 	process.stdout.write('\nApply custom configuration for Playwright tests\n')