fix(KeyValueCache): allow negative TTL for file locking

susnux · susnux · commit 1a2e320c4cba · 2026-07-14T18:58:28.000+02:00
file locking uses negative TTL, returning the default will break.

Signed-off-by: Ferdinand Thiessen &lt;opensource@fthiessen.de&gt;
diff --git a/lib/private/Memcache/KeyValueCache.php b/lib/private/Memcache/KeyValueCache.php
@@ -232,7 +232,7 @@ protected function evalLua(string $scriptName, array $keys, array $args) {
 	 * so fall back to the default and cap it to the maximum.
 	 */
 	private function normalizeTtl(int $ttl): int {
-		if ($ttl <= 0) {
+		if ($ttl === 0) { // we need to allow negative TTL for file locking
 			$ttl = self::DEFAULT_TTL;
 		}
 		return min($ttl, self::MAX_TTL);

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ protected function evalLua(string $scriptName, array $keys, array $args) {`
`232`	`232`	`* so fall back to the default and cap it to the maximum.`
`233`	`233`	`*/`
`234`	`234`	`private function normalizeTtl(int $ttl): int {`
`235`		`- if ($ttl <= 0) {`
	`235`	`+ if ($ttl === 0) { // we need to allow negative TTL for file locking`
`236`	`236`	`$ttl = self::DEFAULT_TTL;`
`237`	`237`	`}`
`238`	`238`	`return min($ttl, self::MAX_TTL);`