Skip to content

Commit 1d16dcc

Browse files
committed
fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional
Signed-off-by: provokateurin <kate@provokateurin.de>
1 parent 5ce0bdc commit 1d16dcc

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

apps/files_external/lib/Lib/Auth/Password/LoginCredentials.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ public function __construct(
6161
->setText($l->t('Log-in credentials, save in database'))
6262
->addParameters([
6363
(new DefinitionParameter('password', $l->t('Password')))
64-
->setType(DefinitionParameter::VALUE_PASSWORD),
64+
->setType(DefinitionParameter::VALUE_PASSWORD)
65+
->setFlag(DefinitionParameter::FLAG_HIDDEN)
66+
->setFlag(DefinitionParameter::FLAG_OPTIONAL),
6567
]);
6668

6769
$eventDispatcher->addServiceListener(UserLoggedInEvent::class, StorePasswordListener::class);

apps/files_external/lib/Lib/Auth/Password/SessionCredentials.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ public function __construct(IL10N $l, CredentialsStore $credentialsStore) {
3535
->setText($l->t('Log-in credentials, save in session'))
3636
->addParameters([
3737
(new DefinitionParameter('password', $l->t('Password')))
38-
->setType(DefinitionParameter::VALUE_PASSWORD),
38+
->setType(DefinitionParameter::VALUE_PASSWORD)
39+
->setFlag(DefinitionParameter::FLAG_HIDDEN)
40+
->setFlag(DefinitionParameter::FLAG_OPTIONAL),
3941
]);
4042
}
4143

0 commit comments

Comments
 (0)