Skip to content

Commit 21bbf78

Browse files
committed
test(share20): replace addToAssertionCount checkbox tests in Share20 ManagerTest
Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 829f0a9 commit 21bbf78

1 file changed

Lines changed: 4 additions & 11 deletions

File tree

tests/lib/Share20/ManagerTest.php

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2059,7 +2059,6 @@ public function testUserCreateChecksShareWithGroupMembersOnlySharedGroup(): void
20592059
->willReturn([]);
20602060

20612061
self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
2062-
$this->addToAssertionCount(1);
20632062
}
20642063

20652064

@@ -2203,7 +2202,6 @@ public function testUserCreateChecksIdenticalPathNotSharedWithUser(): void {
22032202
->willReturn([$share2]);
22042203

22052204
self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
2206-
$this->addToAssertionCount(1);
22072205
}
22082206

22092207

@@ -2301,7 +2299,6 @@ public function testGroupCreateChecksShareWithGroupMembersOnlyInGroup(): void {
23012299
]);
23022300

23032301
self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
2304-
$this->addToAssertionCount(1);
23052302
}
23062303

23072304

@@ -2357,7 +2354,6 @@ public function testGroupCreateChecksPathAlreadySharedWithDifferentGroup(): void
23572354
]);
23582355

23592356
self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
2360-
$this->addToAssertionCount(1);
23612357
}
23622358

23632359

@@ -2377,6 +2373,7 @@ public function testLinkCreateChecksNoLinkSharesAllowed(): void {
23772373
}
23782374

23792375

2376+
#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
23802377
public function testFileLinkCreateChecksNoPublicUpload(): void {
23812378
$share = $this->manager->newShare();
23822379

@@ -2391,7 +2388,6 @@ public function testFileLinkCreateChecksNoPublicUpload(): void {
23912388
]);
23922389

23932390
self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
2394-
$this->addToAssertionCount(1);
23952391
}
23962392

23972393
public function testFolderLinkCreateChecksNoPublicUpload(): void {
@@ -2413,6 +2409,7 @@ public function testFolderLinkCreateChecksNoPublicUpload(): void {
24132409
self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
24142410
}
24152411

2412+
#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
24162413
public function testLinkCreateChecksPublicUpload(): void {
24172414
$share = $this->manager->newShare();
24182415

@@ -2429,9 +2426,9 @@ public function testLinkCreateChecksPublicUpload(): void {
24292426
]);
24302427

24312428
self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
2432-
$this->addToAssertionCount(1);
24332429
}
24342430

2431+
#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
24352432
public function testLinkCreateChecksReadOnly(): void {
24362433
$share = $this->manager->newShare();
24372434

@@ -2448,7 +2445,6 @@ public function testLinkCreateChecksReadOnly(): void {
24482445
]);
24492446

24502447
self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
2451-
$this->addToAssertionCount(1);
24522448
}
24532449

24542450

@@ -2481,14 +2477,13 @@ public function testPathCreateChecksContainsNoSharedMount(): void {
24812477
$this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
24822478

24832479
self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
2484-
$this->addToAssertionCount(1);
24852480
}
24862481

2482+
#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
24872483
public function testPathCreateChecksContainsNoFolder(): void {
24882484
$path = $this->createMock(File::class);
24892485

24902486
self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
2491-
$this->addToAssertionCount(1);
24922487
}
24932488

24942489
public static function dataIsSharingDisabledForUser() {
@@ -4689,7 +4684,6 @@ public function testMoveShareUser(): void {
46894684
$this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);
46904685

46914686
$this->manager->moveShare($share, 'recipient');
4692-
$this->addToAssertionCount(1);
46934687
}
46944688

46954689

@@ -4747,7 +4741,6 @@ public function testMoveShareGroup(): void {
47474741
$this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);
47484742

47494743
$this->manager->moveShare($share, 'recipient');
4750-
$this->addToAssertionCount(1);
47514744
}
47524745

47534746
#[DataProvider('dataTestShareProviderExists')]

0 commit comments

Comments
 (0)