perf(appstore): only send what is needed in app listing

reduces transfered data from 6MiB to <1MiB

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Author: susnux

apps/appstore/lib/Controller/ApiController.php

@@ -76,9 +76,11 @@ public function listCategories(): DataResponse {
 
 	/**
 	 * Get all available apps
+	 *
+	 * @param bool $details - Whether to include detailed appstore information about the app
 	 */
 	#[ApiRoute('GET', '/api/v1/apps')]
-	public function listApps(): DataResponse {
+	public function listApps($details = false): DataResponse {
 		$apps = $this->getAllApps();
 
 		$ignoreMaxApps = $this->config->getSystemValue('app_install_overwrite', []);
@@ -88,12 +90,16 @@ public function listApps(): DataResponse {
 		}
 
 		// Extend existing app details
-		$apps = array_map(function (array $appData) use ($ignoreMaxApps) {
+		$apps = array_map(function (array $appData) use ($ignoreMaxApps, $details) {
 			if (isset($appData['appstoreData'])) {
 				$appstoreData = $appData['appstoreData'];
 				$appData['screenshot'] = $this->createProxyPreviewUrl($appstoreData['screenshots'][0]['url'] ?? '');
 				$appData['category'] = $appstoreData['categories'];
 				$appData['releases'] = $appstoreData['releases'];
+
+				if (!$details) {
+					unset($appData['appstoreData']);
+				}
 			}
 
 			$newVersion = $this->installer->isUpdateAvailable($appData['id']);
@@ -174,6 +180,7 @@ public function enableApp(string $appId, array $groups = []): DataResponse {
 	public function disableApp(string $appId): DataResponse {
 		try {
 			$appId = $this->appManager->cleanAppId($appId);
+			$this->appManager->removeOverwriteNextcloudRequirement($appId);
 			$this->appManager->disableApp($appId);
 			return new DataResponse([]);
 		} catch (\Exception $e) {