Skip to content

Commit 2b1b96b

Browse files
juliusknorrjoshtrichards
authored andcommitted
fix: Expose already used public interface methods
Signed-off-by: Julius Knorr <jus@bitgrid.net>
1 parent 13adaf9 commit 2b1b96b

3 files changed

Lines changed: 20 additions & 2 deletions

File tree

build/psalm-baseline.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1453,7 +1453,6 @@
14531453
</InvalidArgument>
14541454
<UndefinedInterfaceMethod>
14551455
<code><![CDATA[getTemplates]]></code>
1456-
<code><![CDATA[open]]></code>
14571456
</UndefinedInterfaceMethod>
14581457
</file>
14591458
<file src="apps/files/lib/Controller/ViewController.php">

lib/public/DirectEditing/IManager.php

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public function registerDirectEditor(IEditor $directEditor): void;
3737
public function edit(string $token): Response;
3838

3939
/**
40-
* Create a new token based on the file path and editor details
40+
* Create a file and generate a token based on the file path and editor details
4141
*
4242
* @since 18.0.0
4343
* @param string $path
@@ -50,6 +50,19 @@ public function edit(string $token): Response;
5050
*/
5151
public function create(string $path, string $editorId, string $creatorId, $templateId = null): string;
5252

53+
/**
54+
* Create a token based on an existing file path and editor details
55+
*
56+
* @since 33.0.0
57+
* @param string $filePath
58+
* @param string|null $editorId
59+
* @param int|null $fileId
60+
* @return string
61+
* @throws NotPermittedException
62+
* @throws RuntimeException
63+
*/
64+
public function open(string $filePath, ?string $editorId = null, ?int $fileId = null): string;
65+
5366
/**
5467
* Get the token details for a given token
5568
*

lib/public/DirectEditing/IToken.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,10 @@ public function getEditor(): string;
6363
* @return string
6464
*/
6565
public function getUser(): string;
66+
67+
/**
68+
* @since 33.0.0
69+
* @return string
70+
*/
71+
public function getToken(): string;
6672
}

0 commit comments

Comments
 (0)