Merge pull request #61368 from nextcloud/chore/prevent_subadmin_edit

Altahrim · web-flow · commit 3048d9561514 · 2026-06-17T16:02:11.000+02:00
fix: prevent editing delegated admins
diff --git a/lib/private/SubAdmin.php b/lib/private/SubAdmin.php
@@ -256,6 +256,9 @@ public function isUserAccessible(IUser $subadmin, IUser $user): bool {
 		if ($this->groupManager->isAdmin($user->getUID())) {
 			return false;
 		}
+		if ($this->groupManager->isDelegatedAdmin($user->getUID())) {
+			return false;
+		}
 
 		$accessibleGroups = $this->getSubAdminsGroupIds($subadmin);
 		$userGroups = $this->groupManager->getUserGroupIds($user);

Original file line number	Diff line number	Diff line change
`@@ -256,6 +256,9 @@ public function isUserAccessible(IUser $subadmin, IUser $user): bool {`
`256`	`256`	`if ($this->groupManager->isAdmin($user->getUID())) {`
`257`	`257`	`return false;`
`258`	`258`	`}`
	`259`	`+ if ($this->groupManager->isDelegatedAdmin($user->getUID())) {`
	`260`	`+ return false;`
	`261`	`+ }`
`259`	`262`
`260`	`263`	`$accessibleGroups = $this->getSubAdminsGroupIds($subadmin);`
`261`	`264`	`$userGroups = $this->groupManager->getUserGroupIds($user);`