chore(tests): Adapt tests to IUser strict typing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Author: come-nc

apps/dav/tests/unit/Connector/Sabre/AddExtraHeadersPluginTest.php

@@ -81,9 +81,13 @@ function ($method, $callback) use (&$afterPut): void {
 		$this->tree->expects($this->once())->method('getNodeForPath')
 			->willReturn($node);
 
-		$user = $this->createMock(IUser::class);
-		$node->expects($this->once())->method('getOwner')->willReturn($user);
-		$user->expects($this->once())->method('getUID')->willReturn($ownerId);
+		if ($ownerId !== null) {
+			$user = $this->createMock(IUser::class);
+			$node->expects($this->once())->method('getOwner')->willReturn($user);
+			$user->expects($this->once())->method('getUID')->willReturn($ownerId);
+		} else {
+			$node->expects($this->once())->method('getOwner')->willReturn(null);
+		}
 		$node->expects($this->once())->method('getDavPermissions')->willReturn($permissions);
 
 		$matcher = $this->exactly($expectedInvocations);

apps/dav/tests/unit/Connector/Sabre/PrincipalTest.php

@@ -101,6 +101,10 @@ public function testGetPrincipalsByPrefixWithUsers(): void {
 			->expects($this->once())
 			->method('getSystemEMailAddress')
 			->willReturn('bar@nextcloud.com');
+		$barUser
+			->expects($this->once())
+			->method('getDisplayName')
+			->willReturn('bar');
 		$this->userManager
 			->expects($this->once())
 			->method('search')
@@ -189,6 +193,10 @@ public function testGetPrincipalsByPathWithoutMail(): void {
 			->expects($this->once())
 			->method('getUID')
 			->willReturn('foo');
+		$fooUser
+			->expects($this->once())
+			->method('getDisplayName')
+			->willReturn('foo');
 		$this->userManager
 			->expects($this->once())
 			->method('get')
@@ -221,6 +229,10 @@ public function testGetPrincipalsByPathWithMail(): void {
 			->expects($this->once())
 			->method('getUID')
 			->willReturn('foo');
+		$fooUser
+			->expects($this->once())
+			->method('getDisplayName')
+			->willReturn('foo');
 		$this->userManager
 			->expects($this->once())
 			->method('get')

apps/settings/tests/Controller/UsersControllerTest.php

@@ -675,7 +675,7 @@ public static function dataTestSetUserSettingsSubset(): array {
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider(methodName: 'dataTestSaveUserSettings')]
-	public function testSaveUserSettings(array $data, ?string $oldEmailAddress, ?string $oldDisplayName): void {
+	public function testSaveUserSettings(array $data, ?string $oldEmailAddress, string $oldDisplayName): void {
 		$controller = $this->getController();
 		$user = $this->createMock(IUser::class);
 
@@ -690,7 +690,7 @@ public function testSaveUserSettings(array $data, ?string $oldEmailAddress, ?str
 				->with($data[IAccountManager::PROPERTY_EMAIL]['value']);
 		}
 
-		if ($data[IAccountManager::PROPERTY_DISPLAYNAME]['value'] === $oldDisplayName ?? '') {
+		if ($data[IAccountManager::PROPERTY_DISPLAYNAME]['value'] === $oldDisplayName) {
 			$user->expects($this->never())->method('setDisplayName');
 		} else {
 			$user->expects($this->once())->method('setDisplayName')
@@ -775,15 +775,15 @@ public static function dataTestSaveUserSettings(): array {
 					IAccountManager::PROPERTY_DISPLAYNAME => ['value' => 'john doe'],
 				],
 				'john@example.com',
-				null
+				''
 			],
 			[
 				[
 					IAccountManager::PROPERTY_EMAIL => ['value' => 'john@example.com'],
 					IAccountManager::PROPERTY_DISPLAYNAME => ['value' => 'john doe'],
 				],
 				'JOHN@example.com',
-				null
+				''
 			],
 		];
 	}

tests/lib/Contacts/ContactsMenu/Providers/LocalTimeProviderTest.php

@@ -186,10 +186,6 @@ public function testProcessNoUser(): void {
 			->with('UID')
 			->willReturn('user1');
 
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn(null);
-
 		$entry->expects($this->never())
 			->method('addAction');
 

tests/lib/TaskProcessing/TaskProcessingTest.php

@@ -912,7 +912,7 @@ public function testProviderShouldBeRegisteredAndTaskWithFilesFailValidation():
 			new ServiceRegistration('test', AsyncProvider::class)
 		]);
 		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())->method('getUID')->willReturn(null);
+		$user->expects($this->any())->method('getUID')->willReturn('uid');
 		$mount = $this->createMock(ICachedMountInfo::class);
 		$mount->expects($this->any())->method('getUser')->willReturn($user);
 		$this->userMountCache->expects($this->any())->method('getMountsForFileId')->willReturn([$mount]);